aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua Cohen" <>
Subject Re: Review Request 29770: Add support for --version flag to client.
Date Sat, 10 Jan 2015 00:04:56 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 10, 2015, 12:04 a.m.)

Review request for Aurora, Kevin Sweeney and Bill Farner.


- Fix end to end tests to rsync symlinks
- Add end to end test for the output of aurora --version
- Fix end to end test cleanup to use v2 syntax

Bugs: AURORA-970 and AURORA-989

Repository: aurora


Add support for --version flag to client.

Right now it just prints out the version from .auroraversion. We no longer print out the build
sha/date from PEX_INFO.

The one wonky thing here is that in order to read .auroraversion from the client, I'm symlinking
it under src/main/aurora/apache/client/cli. Open to better solutions if anyone can think of

Diffs (updated)

  examples/vagrant/ 490a8194424d4adddc2d9b3a7a7f0e579bea6c06 
  src/main/python/apache/aurora/client/cli/.auroraversion PRE-CREATION 
  src/main/python/apache/aurora/client/cli/BUILD c7ca61dc5ffc18c95820d38d55228ffad58412ea

  src/main/python/apache/aurora/client/cli/ 29998833b50cca2c10eb5c248de9ee1cb60c7a5c

  src/test/python/apache/aurora/client/cli/ PRE-CREATION 
  src/test/sh/org/apache/aurora/e2e/ 31646425233470b5f87ab50ef4504264f235f48a

  src/test/sh/org/apache/aurora/e2e/ 578662ccd1735ebf500d066b3cc17b30f635c15f



./pants build src/test/python/apache/aurora/client::


Joshua Cohen

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message