aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 29770: Add support for --version flag to client.
Date Fri, 09 Jan 2015 23:27:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29770/#review67548
-----------------------------------------------------------


Err, no-ship.  This breaks aurorabuild in vagrant:

```
$ aurorabuild client
sending incremental file list
skipping non-regular file "src/main/python/apache/aurora/client/cli/.auroraversion"

sent 44.29K bytes  received 437 bytes  29.82K bytes/sec
total size is 13.36M  speedup is 298.60
fatal: Not a git repository (or any of the parent directories): .git
Build operating on top level addresses: set([BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/client/cli/BUILD,
aurora)])
fatal: Not a git repository (or any of the parent directories): .git
Building PythonBinary PythonBinary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/client/cli/BUILD,
aurora)):
Problem executing PythonBuilder for targets OrderedSet([PythonBinary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/client/cli/BUILD,
aurora)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/client/cli/BUILD,
client_lib)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/client/cli/BUILD,
cli)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/client/api/BUILD,
command_runner)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/client/api/BUILD,
api)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/client/api/BUILD,
restarter)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/client/api/BUILD,
instance_watcher)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/client/api/BUILD,
scheduler_client)), PythonLibrary(BuildFileAddress(/ho
 me/vagrant/aurora/src/main/python/apache/aurora/common/auth/BUILD, auth)), PythonThriftLibrary(BuildFileAddress(/home/vagrant/aurora/api/src/main/thrift/org/apache/aurora/gen/BUILD,
py-thrift)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/common/BUILD,
cluster)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/common/BUILD,
transport)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/client/api/BUILD,
scheduler_mux)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/client/api/BUILD,
error_handling_thread)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/client/api/BUILD,
task_util)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/client/BUILD,
base)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/common/BUILD,
common)), PythonLibrary(BuildFi
 leAddress(/home/vagrant/aurora/src/main/python/apache/aurora/common/BUILD, aurora_job_key)),
PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/common/BUILD,
cluster_option)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/common/BUILD,
clusters)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/common/BUILD,
pex_version)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/common/BUILD,
http_signaler)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/common/BUILD,
shellify)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/api/src/main/thrift/org/apache/aurora/gen/BUILD,
py-thrift-packaged)), PythonThriftLibrary(BuildFileAddress(/home/vagrant/aurora/api/src/main/thrift/org/apache/aurora/gen/BUILD,
py-thrift-test)), PythonThriftLibrary(BuildFileAddress(/home/vagrant/aurora/api/src/main/thrift/org/apache/aurora/gen/BU
 ILD, py-thrift-storage)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/client/api/BUILD,
updater_util)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/client/api/BUILD,
sla)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/client/api/BUILD,
updater)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/client/api/BUILD,
job_monitor)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/client/api/BUILD,
quota_check)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/thermos/config/BUILD,
schema)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/thermos/common/BUILD,
planner)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/config/BUILD,
schema)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/conf
 ig/schema/BUILD, schema)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/client/hooks/BUILD,
hooks)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/client/BUILD,
api)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/client/BUILD,
config)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/client/BUILD,
binding_helper)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/config/BUILD,
config)), PythonLibrary(BuildFileAddress(/home/vagrant/aurora/src/main/python/apache/aurora/client/BUILD,
factory))]): Traceback (most recent call last):
  File "/home/vagrant/aurora/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/commands/build.py",
line 130, in _python_build
    debug=self._verbose)
  File "/home/vagrant/aurora/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/python_builder.py",
line 52, in build
    conn_timeout=conn_timeout).run()
  File "/home/vagrant/aurora/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/binary_builder.py",
line 53, in run
    env = self.chroot.dump()
  File "/home/vagrant/aurora/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/python_chroot.py",
line 159, in dump
    self._dump_library(lib)
  File "/home/vagrant/aurora/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/python_chroot.py",
line 110, in _dump_library
    self._builder.add_resource)
  File "/home/vagrant/aurora/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/python_chroot.py",
line 101, in copy_to_chroot
    add_function(src, path)
  File "/home/vagrant/aurora/build-support/pants.venv/lib/python2.7/site-packages/pex/pex_builder.py",
line 95, in add_resource
    self._chroot.link(filename, env_filename, "resource")
  File "/home/vagrant/aurora/build-support/pants.venv/lib/python2.7/site-packages/pex/common.py",
line 242, in link
    os.link(abs_src, abs_dst)
OSError: [Errno 2] No such file or directory
```

- Bill Farner


On Jan. 9, 2015, 7:38 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29770/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 7:38 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-970 and AURORA-989
>     https://issues.apache.org/jira/browse/AURORA-970
>     https://issues.apache.org/jira/browse/AURORA-989
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add support for --version flag to client.
> 
> Right now it just prints out the version from .auroraversion. We no longer print out
the build sha/date from PEX_INFO.
> 
> The one wonky thing here is that in order to read .auroraversion from the client, I'm
symlinking it under src/main/aurora/apache/client/cli. Open to better solutions if anyone
can think of something.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/.auroraversion PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/BUILD c7ca61dc5ffc18c95820d38d55228ffad58412ea

>   src/main/python/apache/aurora/client/cli/__init__.py 29998833b50cca2c10eb5c248de9ee1cb60c7a5c

>   src/test/python/apache/aurora/client/cli/test_version.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29770/diff/
> 
> 
> Testing
> -------
> 
> ./pants build src/test/python/apache/aurora/client::
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message