aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 29734: Fix reviewbot to skip reviews that have no diffs.
Date Fri, 09 Jan 2015 00:35:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29734/#review67344
-----------------------------------------------------------

Ship it!



build-support/jenkins/review_feedback.py
<https://reviews.apache.org/r/29734/#comment111341>

    "if not diffs:" should do the same


- Maxim Khutornenko


On Jan. 9, 2015, 12:31 a.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29734/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 12:31 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix reviewbot to skip reviews that have no diffs.
> 
> We're seeing [failures](https://builds.apache.org/job/AuroraBot/724/console) of the AuroraBot
job for a [review](https://reviews.apache.org/r/28943/) that has no diffs. This should fix
those cases.
> 
> 
> Diffs
> -----
> 
>   build-support/jenkins/review_feedback.py bd2c9941960645f662ec835c2baa4d1f3dae7d79 
> 
> Diff: https://reviews.apache.org/r/29734/diff/
> 
> 
> Testing
> -------
> 
> Ran locally, it didn't crash on r28943
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message