aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@twopensource.com>
Subject Re: Review Request 29696: Fix bad call to print_out causing 'job inspect --raw' to fail.
Date Thu, 08 Jan 2015 18:05:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29696/#review67228
-----------------------------------------------------------



src/test/python/apache/aurora/client/cli/test_inspect.py
<https://reviews.apache.org/r/29696/#comment111105>

    This test doesn't communicate with the scheduler so why do we mock this out?



src/test/python/apache/aurora/client/cli/test_inspect.py
<https://reviews.apache.org/r/29696/#comment111107>

    Is this patch needed?


- Zameer Manji


On Jan. 7, 2015, 6:19 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29696/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2015, 6:19 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-990
>     https://issues.apache.org/jira/browse/AURORA-990
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> In the course of this, i took a stab at cleaning up the unit test to remove unnecessary
mocking and avoid writing to a temporary file.  The nice outcome of the mock removal is that
the job configuration in our code is identical to what would appear in a configuration file.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 395819fdf24b7919b32be51060fb5b581c8e1514

>   src/main/python/apache/aurora/client/cli/jobs.py 744d53405081e75b9aedcdcb7e4a823a2e0e743f

>   src/test/python/apache/aurora/client/cli/test_inspect.py 1c07d912c95eafa292d5451f4d6c72e9a711dae0

> 
> Diff: https://reviews.apache.org/r/29696/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message