aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 29672: Fixing failed test.
Date Wed, 07 Jan 2015 21:48:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29672/#review67099
-----------------------------------------------------------



src/test/python/apache/aurora/client/commands/test_diff.py
<https://reviews.apache.org/r/29672/#comment110929>

    While you're here mind changing these to kwargs form? That will make this test actually
fail if the thrift API renames or removes these fields.


- Kevin Sweeney


On Jan. 7, 2015, 1:30 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29672/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2015, 1:30 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Deepcopy chokes on a mock object. No idea how it could ever pass before.
> 
> 
> Diffs
> -----
> 
>   src/test/python/apache/aurora/client/commands/test_diff.py 81cdd116b324cb985f6fe05f0e0e50984bd5095c

> 
> Diff: https://reviews.apache.org/r/29672/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/client/commands:core
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message