aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 29015: Suppressing duplicate error messages.
Date Tue, 06 Jan 2015 23:49:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29015/
-----------------------------------------------------------

(Updated Jan. 6, 2015, 11:49 p.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
-------

Added vagrant output example.


Bugs: AURORA-968
    https://issues.apache.org/jira/browse/AURORA-968


Repository: aurora


Description
-------

Problems addressed:
- Duplicate output due to relying on both `context.print_err()` and `raise CommandError`
- Duplicate output in case of missing err_msg in `check_and_log_response()`
- Inconsistent messaging and error handling cases


Diffs
-----

  src/main/python/apache/aurora/client/cli/context.py b1ffc05ebd520e91be58704615c5a12c62e75f03

  src/main/python/apache/aurora/client/cli/cron.py 1f1efdb47eaf09af84813ae1af210c5ebdde7d0c

  src/main/python/apache/aurora/client/cli/jobs.py 8bdb7f488f68b10b767ced627e55e57698e4f5f2

  src/main/python/apache/aurora/client/cli/quota.py 137aab1285a9732a3b65aee65948e836df3c7cac

  src/main/python/apache/aurora/client/cli/task.py a70f908de63904f9d3bd3776f60432d9329931e7

  src/main/python/apache/aurora/client/cli/update.py d1d0b2946c0513381345d90fabe22c1b7c6b8ca9

  src/test/python/apache/aurora/client/cli/test_create.py 9aaf82a485e2c517848ad7e0b2fc41efa017bbbd

  src/test/python/apache/aurora/client/cli/test_kill.py 3036f9cdf9e4805229664e64445fec5ec222be8e

  src/test/python/apache/aurora/client/cli/test_quota.py 202cc45ffa7efb5b5268bf41ca14104504735478

  src/test/python/apache/aurora/client/cli/test_restart.py c19b21dd99dded0fdc631cef90997e2f2bd1156e

  src/test/python/apache/aurora/client/cli/test_supdate.py eafb909098e6f757db1522d5cb605ff04a96e8b6

  src/test/python/apache/aurora/client/cli/test_update.py 044e6099a81bfa241a317b6a6b0f6f46da49bdc2

  src/test/python/apache/aurora/client/cli/util.py 6dba1855f8951d38882c0d5b01a5a609b774d00f


Diff: https://reviews.apache.org/r/29015/diff/


Testing (updated)
-------

./pants src/test/python/apache/aurora/client/cli:all
Also, visually verified in vagrant:

Before:
vagrant@vagrant-ubuntu-trusty-64:~$ aurora job killall devcluster/www-data/prod/hello
 INFO] Checking status of devcluster/www-data/prod/hello
 INFO] 
 INFO] Killing tasks for job: devcluster/www-data/prod/hello
 INFO] Instances to be killed: [0]
Tasks were not killed in time.
Kill of shards [0] failed with error:
Exceeded maximum number of errors while killing instances
Error executing command: Exceeded maximum number of errors while killing instances

After:
vagrant@vagrant-ubuntu-trusty-64:~$ aurora job killall devcluster/www-data/prod/hello
 INFO] Checking status of devcluster/www-data/prod/hello
 INFO] 
 INFO] Killing tasks for job: devcluster/www-data/prod/hello
 INFO] Instances to be killed: [0]
Instances [0] were not killed in time
Error executing command: Exceeded maximum number of errors while killing instances


Thanks,

Maxim Khutornenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message