Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 06F61104A3 for ; Wed, 17 Dec 2014 20:41:07 +0000 (UTC) Received: (qmail 28471 invoked by uid 500); 17 Dec 2014 20:41:06 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 28427 invoked by uid 500); 17 Dec 2014 20:41:06 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 28401 invoked by uid 99); 17 Dec 2014 20:41:06 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Dec 2014 20:41:06 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 17 Dec 2014 20:41:04 +0000 Received: (qmail 28120 invoked by uid 99); 17 Dec 2014 20:40:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Dec 2014 20:40:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 02B421D245F; Wed, 17 Dec 2014 20:40:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4256505628651524909==" MIME-Version: 1.0 Subject: Re: Review Request 29171: Fix test_executor_vars so that it doesn't attempt to get a real PEX-INFO. From: "Kevin Sweeney" To: "Joe Smith" Cc: "Aurora" , "Brian Wickman" , "Kevin Sweeney" Date: Wed, 17 Dec 2014 20:40:41 -0000 Message-ID: <20141217204041.12934.44557@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/29171/ X-Sender: "Kevin Sweeney" References: <20141217191834.12942.7009@reviews.apache.org> In-Reply-To: <20141217191834.12942.7009@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============4256505628651524909== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Dec. 17, 2014, 11:18 a.m., Kevin Sweeney wrote: > > src/test/python/apache/aurora/executor/test_executor_vars.py, line 34 > > > > > > Can this test above be removed? > > Brian Wickman wrote: > should I just remove all tag exporting from the executor_vars? I think they're unused, plus likely twitter specific. > > Kevin Sweeney wrote: > +1 to that, discard this diff in favor of an upstream patch My mistake, this *is* an upstream patch - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29171/#review65350 ----------------------------------------------------------- On Dec. 17, 2014, 12:31 p.m., Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29171/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 12:31 p.m.) > > > Review request for Aurora and Joe Smith. > > > Repository: aurora > > > Description > ------- > > Fix test_executor_vars so that it doesn't attempt to get a real PEX-INFO. > > > Diffs > ----- > > src/main/python/apache/aurora/executor/executor_vars.py 7c018271724ffab2ff6930e5802a48b50a39dded > src/test/python/apache/aurora/executor/BUILD 3095f2a148b21365ea2f500039adb5710a187fa1 > src/test/python/apache/aurora/executor/test_executor_vars.py af1c7b7d78b89ae713d6db96cf766b596fa91c55 > > Diff: https://reviews.apache.org/r/29171/diff/ > > > Testing > ------- > > ./pants src/test/python/apache/aurora/executor:executor_vars -v > > > Thanks, > > Brian Wickman > > --===============4256505628651524909==--