Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F24A010193 for ; Wed, 10 Dec 2014 01:08:26 +0000 (UTC) Received: (qmail 36163 invoked by uid 500); 10 Dec 2014 01:08:26 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 36119 invoked by uid 500); 10 Dec 2014 01:08:26 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 36107 invoked by uid 99); 10 Dec 2014 01:08:25 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Dec 2014 01:08:25 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 10 Dec 2014 01:08:24 +0000 Received: (qmail 34355 invoked by uid 99); 10 Dec 2014 01:08:04 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Dec 2014 01:08:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 31BB11D2317; Wed, 10 Dec 2014 01:08:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5064033426632860896==" MIME-Version: 1.0 Subject: Re: Review Request 28883: Fixing @Timed method visibility. From: "Kevin Sweeney" To: "Bill Farner" Cc: "Aurora" , "Maxim Khutornenko" , "Kevin Sweeney" Date: Wed, 10 Dec 2014 01:08:02 -0000 Message-ID: <20141210010802.5765.75282@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/28883/ X-Sender: "Kevin Sweeney" References: <20141210005950.5766.97496@reviews.apache.org> In-Reply-To: <20141210005950.5766.97496@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============5064033426632860896== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28883/#review64486 ----------------------------------------------------------- Ship it! Ship It! - Kevin Sweeney On Dec. 9, 2014, 4:59 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28883/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2014, 4:59 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-966 > https://issues.apache.org/jira/browse/AURORA-966 > > > Repository: aurora > > > Description > ------- > > Fixing @Timed method visibility. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java ead9d28100673440168a32d114ecaa15874978a6 > > Diff: https://reviews.apache.org/r/28883/diff/ > > > Testing > ------- > > Tested in vagrant: > ``` > task_schedule_attempt_events 5 > task_schedule_attempt_events_per_sec 0.9989254079902053 > task_schedule_attempt_locked_events 5 > task_schedule_attempt_locked_events_per_sec 1.0019749236357087 > task_schedule_attempt_locked_nanos_per_event 1570156.6526848162 > task_schedule_attempt_locked_nanos_total 45453749 > task_schedule_attempt_locked_nanos_total_per_sec 1573257.5921699686 > task_schedule_attempt_nanos_per_event 1759287.885810068 > task_schedule_attempt_nanos_total 48291560 > task_schedule_attempt_nanos_total_per_sec 1757397.369105048 > ``` > > > Thanks, > > Maxim Khutornenko > > --===============5064033426632860896==--