Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DB1B7C8CF for ; Tue, 9 Dec 2014 02:34:08 +0000 (UTC) Received: (qmail 98236 invoked by uid 500); 9 Dec 2014 02:34:08 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 98193 invoked by uid 500); 9 Dec 2014 02:34:08 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 98182 invoked by uid 99); 9 Dec 2014 02:34:07 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Dec 2014 02:34:07 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 09 Dec 2014 02:34:06 +0000 Received: (qmail 97109 invoked by uid 99); 9 Dec 2014 02:33:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Dec 2014 02:33:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D35C11D2245; Tue, 9 Dec 2014 02:33:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0646352350256887626==" MIME-Version: 1.0 Subject: Re: Review Request 28831: Changing the default --batch-size to 1. From: "Bill Farner" To: "Bill Farner" Cc: "Aurora" , "Maxim Khutornenko" Date: Tue, 09 Dec 2014 02:33:40 -0000 Message-ID: <20141209023340.26419.62666@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/28831/ X-Sender: "Bill Farner" References: <20141209012532.5765.99365@reviews.apache.org> In-Reply-To: <20141209012532.5765.99365@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============0646352350256887626== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28831/#review64333 ----------------------------------------------------------- thanks for the drive-by cleanups! src/test/python/apache/aurora/client/cli/test_kill.py I believe this should be of the form `assert foo.mock_calls == [x]` Ditto elsewhere. - Bill Farner On Dec. 9, 2014, 1:25 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28831/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2014, 1:25 a.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-961 > https://issues.apache.org/jira/browse/AURORA-961 > > > Repository: aurora > > > Description > ------- > > Also, cleaned up kill command tests a bit. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/options.py e844cf340583b631ce194352f403bbaec71655b7 > src/test/python/apache/aurora/client/cli/test_kill.py 1eda72af4c19831ae27733f506858e67772b2075 > src/test/python/apache/aurora/client/cli/util.py 67d7eaa6eff4e1dbaaa485166e084812a4f04074 > > Diff: https://reviews.apache.org/r/28831/diff/ > > > Testing > ------- > > ./pants src/test/python/apache/aurora/client/cli:all > > > Thanks, > > Maxim Khutornenko > > --===============0646352350256887626==--