Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 769A010B6B for ; Fri, 5 Dec 2014 02:00:56 +0000 (UTC) Received: (qmail 60188 invoked by uid 500); 5 Dec 2014 02:00:56 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 60146 invoked by uid 500); 5 Dec 2014 02:00:56 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 60128 invoked by uid 99); 5 Dec 2014 02:00:55 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Dec 2014 02:00:55 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 05 Dec 2014 02:00:32 +0000 Received: (qmail 59946 invoked by uid 99); 5 Dec 2014 02:00:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Dec 2014 02:00:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1B2321D2204; Fri, 5 Dec 2014 02:00:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4743637827815962771==" MIME-Version: 1.0 Subject: Re: Review Request 28682: Drop custom thrift doc generator in favor of the one included in thrift. From: "Kevin Sweeney" To: "Zameer Manji" , "Kevin Sweeney" Cc: "Bill Farner" , "Aurora" Date: Fri, 05 Dec 2014 02:00:28 -0000 Message-ID: <20141205020028.32526.65133@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/28682/ X-Sender: "Kevin Sweeney" References: <20141205005827.32525.23314@reviews.apache.org> In-Reply-To: <20141205005827.32525.23314@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============4743637827815962771== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28682/#review63949 ----------------------------------------------------------- Ship it! Ship It! - Kevin Sweeney On Dec. 4, 2014, 4:58 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28682/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 4:58 p.m.) > > > Review request for Aurora, Kevin Sweeney and Zameer Manji. > > > Bugs: AURORA-947 > https://issues.apache.org/jira/browse/AURORA-947 > > > Repository: aurora > > > Description > ------- > > There's a subtle change in `buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy` to avoid generating thermos' thrift for the scheduler. This prevents a conflict on index.html. > > > Diffs > ----- > > build.gradle 2699db8f9457a07d995d0707b69d10bdb171b873 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy 31934f551da808951144cd474255105a9d198854 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy e6114cf0ec557b8d365140b5f413c69a61dc1563 > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 8955a362d8de73263c41ae0184ca384a9e12c6f2 > src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py ca2581cfc38a5873143e2ca8dc6e23b8ec389421 > src/main/resources/scheduler/assets/index.html cc62d9ea9eb5923c7bd926e1e1a45ebbeaeb0287 > > Diff: https://reviews.apache.org/r/28682/diff/ > > > Testing > ------- > > ./gradlew run, clicked around. > > > Thanks, > > Bill Farner > > --===============4743637827815962771==--