Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8685810904 for ; Thu, 4 Dec 2014 19:06:59 +0000 (UTC) Received: (qmail 7644 invoked by uid 500); 4 Dec 2014 19:06:59 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 7601 invoked by uid 500); 4 Dec 2014 19:06:59 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 7590 invoked by uid 99); 4 Dec 2014 19:06:58 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Dec 2014 19:06:58 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 04 Dec 2014 19:06:57 +0000 Received: (qmail 3552 invoked by uid 99); 4 Dec 2014 19:06:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Dec 2014 19:06:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D13651D217E; Thu, 4 Dec 2014 19:06:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2549092136462526660==" MIME-Version: 1.0 Subject: Re: Review Request 28696: Use abstract decorators in CommandLine class. From: "Kevin Sweeney" To: "Bill Farner" , "Kevin Sweeney" Cc: "Aurora" , "Zameer Manji" Date: Thu, 04 Dec 2014 19:06:34 -0000 Message-ID: <20141204190634.32525.6128@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/28696/ X-Sender: "Kevin Sweeney" References: <20141204074047.32525.60832@reviews.apache.org> In-Reply-To: <20141204074047.32525.60832@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============2549092136462526660== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28696/#review63882 ----------------------------------------------------------- Ship it! Ship It! - Kevin Sweeney On Dec. 3, 2014, 11:40 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28696/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 11:40 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Use abstract decorators in CommandLine class. This ensures the name property and register_nouns method are implemented. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 > > Diff: https://reviews.apache.org/r/28696/diff/ > > > Testing > ------- > > ./pants src/test/python/apache/aurora/client:: > > > Thanks, > > Zameer Manji > > --===============2549092136462526660==--