Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D0C95C1BC for ; Thu, 4 Dec 2014 12:31:58 +0000 (UTC) Received: (qmail 85297 invoked by uid 500); 4 Dec 2014 12:31:58 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 85260 invoked by uid 500); 4 Dec 2014 12:31:58 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 87325 invoked by uid 99); 4 Dec 2014 00:16:58 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Dec 2014 00:16:58 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 04 Dec 2014 00:16:57 +0000 Received: (qmail 86299 invoked by uid 99); 4 Dec 2014 00:15:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Dec 2014 00:15:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CC8281D21CE; Thu, 4 Dec 2014 00:15:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3574830995196351971==" MIME-Version: 1.0 Subject: Re: Review Request 28623: Remove getVersion RPC and DEPRECATEDversion Response field. From: "David McLaughlin" To: "Kevin Sweeney" , "David McLaughlin" Cc: "Bill Farner" , "Aurora" Date: Thu, 04 Dec 2014 00:15:19 -0000 Message-ID: <20141204001519.32525.31721@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "David McLaughlin" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/28623/ X-Sender: "David McLaughlin" References: <20141203021338.32526.4776@reviews.apache.org> In-Reply-To: <20141203021338.32526.4776@reviews.apache.org> Reply-To: "David McLaughlin" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============3574830995196351971== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28623/#review63783 ----------------------------------------------------------- Ship it! Ship It! - David McLaughlin On Dec. 3, 2014, 2:13 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28623/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 2:13 a.m.) > > > Review request for Aurora, David McLaughlin and Kevin Sweeney. > > > Bugs: AURORA-143 and AURORA-467 > https://issues.apache.org/jira/browse/AURORA-143 > https://issues.apache.org/jira/browse/AURORA-467 > > > Repository: aurora > > > Description > ------- > > Remove getVersion RPC and DEPRECATEDversion Response field. > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift 6b63f04a7113527e26d7f38e877b0ebd07822108 > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 0898c62315c5a47628ad629182c3177c86a00bce > src/main/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptor.java 3406722067af40a91fe39340d94ee03d20d7ddbd > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d687f572b467a76e79d55ea1d7eb0abf7ec61bbd > src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 04979084b5352d3044bd3c2ba7071e10d9992765 > src/test/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptorTest.java 840b3f88e7de306fa0af73593b5bac6cc00528da > > Diff: https://reviews.apache.org/r/28623/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > > --===============3574830995196351971==--