Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 72AD110F40 for ; Tue, 2 Dec 2014 19:49:59 +0000 (UTC) Received: (qmail 64501 invoked by uid 500); 2 Dec 2014 19:49:59 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 64459 invoked by uid 500); 2 Dec 2014 19:49:59 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 64448 invoked by uid 99); 2 Dec 2014 19:49:58 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Dec 2014 19:49:58 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 02 Dec 2014 19:49:57 +0000 Received: (qmail 63482 invoked by uid 99); 2 Dec 2014 19:49:37 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Dec 2014 19:49:37 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id ADCCE1D2120; Tue, 2 Dec 2014 19:49:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2675402317295550325==" MIME-Version: 1.0 Subject: Re: Review Request 28572: Minimize the state consumed when collecting preemption victims. From: "Kevin Sweeney" To: "Zameer Manji" , "Kevin Sweeney" Cc: "Bill Farner" , "Aurora" Date: Tue, 02 Dec 2014 19:49:35 -0000 Message-ID: <20141202194935.32525.10563@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/28572/ X-Sender: "Kevin Sweeney" References: <20141202190442.32526.11931@reviews.apache.org> In-Reply-To: <20141202190442.32526.11931@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============2675402317295550325== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28572/#review63574 ----------------------------------------------------------- Ship it! Ship It! - Kevin Sweeney On Dec. 2, 2014, 11:04 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28572/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2014, 11:04 a.m.) > > > Review request for Aurora, Kevin Sweeney and Zameer Manji. > > > Bugs: AURORA-121 > https://issues.apache.org/jira/browse/AURORA-121 > > > Repository: aurora > > > Description > ------- > > This should be the last step before creating a caching `ClusterState` implementation. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterState.java 4f0019a1a1272e27e600c47641bbbba05d320035 > src/main/java/org/apache/aurora/scheduler/async/preemptor/LiveClusterState.java 9d83acc4177076411c5ce6c8304fcf75cb029597 > src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionVictim.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java f013383b095968b0de6e917d2311c85d6afe53f7 > src/test/java/org/apache/aurora/scheduler/async/preemptor/LiveClusterStateTest.java 8f91ff684dddc0591e71503afc0f999e508b7dbe > > Diff: https://reviews.apache.org/r/28572/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > > --===============2675402317295550325==--