aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Niemitz" <st...@tellapart.com>
Subject Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper
Date Wed, 31 Dec 2014 00:23:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29464/
-----------------------------------------------------------

(Updated Dec. 31, 2014, 12:23 a.m.)


Review request for Aurora.


Changes
-------

This last change also modifies thermos_executor to use the hostname specified by the mesos-slave
(or the default if nothing was specified on the slave).  It uses this both for publishing
into ZooKeepr and writing to the checkpoint file.


Repository: aurora


Description
-------

I've added a new flag for the aurora scheduler, -hostname which can override the scheduler
server address published into ZK.

This is useful for cases such as running the scheduler in EC2, where the autodetected local
address is actual an interal IP and not the public address of the machine.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 360e161b6c3f6fd412c7e8de7f1b9a3af109593c

  src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java PRE-CREATION

  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94

  src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java cf173850635572c0df38bdd5cb14de8ce2016bf7

  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 9df9b4b79c0c7d29c5088409bf15c0d32a621df0

  src/main/python/apache/aurora/executor/common/announcer.py 9e5bdc3885e76d8d03aa946caac9fdec7e1e9186

  src/main/python/apache/aurora/executor/executor_base.py 1db97cc8c12752d4eca339a7680ba963a66ffbce

  src/main/python/apache/aurora/executor/thermos_task_runner.py 5e4bd65537d186459003c0b9434f1b769e04f448

  src/main/python/apache/thermos/core/runner.py 8aac6b50c66080abbb5308b367e9f74c487f42e3 
  src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java
PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 5e54364a49a208bd5f19b9649633dc8feca591e9

  src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java fbc3da3ab239b67ce3012d5a14fccd3ccb20a241

  src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java c3bf5ea4cbeaad03e187f84215b86531d55c25b3


Diff: https://reviews.apache.org/r/29464/diff/


Testing
-------


Thanks,

Steve Niemitz


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message