aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Review Request 29216: Removing client v1 code.
Date Thu, 18 Dec 2014 22:32:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29216/
-----------------------------------------------------------

Review request for Aurora, Kevin Sweeney and Zameer Manji.


Bugs: AURORA-775
    https://issues.apache.org/jira/browse/AURORA-775


Repository: aurora


Description
-------

Despite the diff size, the changes are very limited in scope. The majority of green/yellow
is consolidating admin-related code under /apache/aurora/admin. The rest is removals and renamings
to get rid of "v2". 

This diff has minor overlaps with https://reviews.apache.org/r/28971 in vagrant and target
renaming parts.


Diffs
-----

  examples/vagrant/aurorabuild.sh 69983d0140b76c6869cd04e55d760f3e3a1e4262 
  src/main/python/apache/aurora/admin/BUILD f874264bdf07a9cbb2f0990739be3c95f851b040 
  src/main/python/apache/aurora/client/BUILD 2a66825426923fd7e5b7c70101747bc292208e19 
  src/main/python/apache/aurora/client/api/BUILD 65e5a85e23c4c698356c8b45c45943e560c1bcd5

  src/main/python/apache/aurora/client/api/disambiguator.py 6a78ccd44533ef327f751a08c9e2e16555354d97

  src/main/python/apache/aurora/client/base.py a897e879dfda7340d7561247d3fa7cda2dbb5bc6 
  src/main/python/apache/aurora/client/bin/BUILD 671bd78148788d885e50a93bdc006361297a63a2

  src/main/python/apache/aurora/client/bin/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd

  src/main/python/apache/aurora/client/bin/aurora_admin.py 136cf601f0cc137f5111f1ddec5fd823375626b6

  src/main/python/apache/aurora/client/bin/aurora_client.py 4999265af358d06d236e819bd600426f4574742c

  src/main/python/apache/aurora/client/cli/BUILD e61cdfb5f3370ac1c5069632d4158f5ee641bc3a

  src/main/python/apache/aurora/client/cli/bridge.py 227abf8e21186dd079bc6ce6ff0408a973ad3ab8

  src/main/python/apache/aurora/client/commands/BUILD f2564839ea782b9b2492afb37756db3f0e7fa2ac

  src/main/python/apache/aurora/client/commands/__init__.py  
  src/main/python/apache/aurora/client/commands/admin.py 4b86c5a5851206d875f07c9afa9d68a8f57f5ab7

  src/main/python/apache/aurora/client/commands/core.py 7b970e8872c73a30947ce8f407c37da3d06f20df

  src/main/python/apache/aurora/client/commands/help.py f79e9718fa9fd8f69331d60e95988f89105089f4

  src/main/python/apache/aurora/client/commands/maintenance.py 5321eb6e8d8a15a5e2115e3664d5f12990b67617

  src/main/python/apache/aurora/client/commands/run.py 6844ac3eb977f5debfad003eb9e6590d3bb2022e

  src/main/python/apache/aurora/client/commands/ssh.py b0916edb0f90906e07a80302473ae7a7446f62a9

  src/main/python/apache/aurora/client/options.py f43aced0131cea3adac018d8abcd938ad45af35f

  src/test/python/apache/aurora/admin/BUILD 3a216809d1e31247f7d01451fcc7fd877a4c1fb2 
  src/test/python/apache/aurora/client/BUILD e31e434723a8aa884bc528987b8aa98077ec0548 
  src/test/python/apache/aurora/client/api/BUILD 2c0c4070cc1f1784b1d4e7f9cd8aac236e97be75

  src/test/python/apache/aurora/client/api/api_util.py  
  src/test/python/apache/aurora/client/api/test_api.py c91e74e78a35eef7fc48dcb2a00d1bd3c6cb7291

  src/test/python/apache/aurora/client/api/test_disambiguator.py 72e98d266e96104552e6891dad737701a04f29c1

  src/test/python/apache/aurora/client/api/test_job_monitor.py 1e7a8793e821da3ed53e0ea2b073ea434993a2c6

  src/test/python/apache/aurora/client/api/test_quota_check.py 2fc76d21ca63ae7f33b1e03ccb88f52fe82dc76c

  src/test/python/apache/aurora/client/api/test_task_util.py 048aff6874259810efea463df1ca2a1fdc419ca1

  src/test/python/apache/aurora/client/cli/BUILD 4b5817e667281525295730664f96dedeb3e02779

  src/test/python/apache/aurora/client/cli/test_bridge.py 6c40bf74677aa6306657dd30016cc380ac20f989

  src/test/python/apache/aurora/client/cli/test_cron.py c748212febf5867f5f7cc54e34bf91a8890d9999

  src/test/python/apache/aurora/client/cli/util.py 6dba1855f8951d38882c0d5b01a5a609b774d00f

  src/test/python/apache/aurora/client/commands/BUILD 86ab65e40536a28bddbf8efc9148111ba1518465

  src/test/python/apache/aurora/client/commands/__init__.py  
  src/test/python/apache/aurora/client/commands/test_admin.py c7d970c805e7e56f9ecce159c93cd2dac14d1fca

  src/test/python/apache/aurora/client/commands/test_admin_sla.py 74fc79c23b4718fe0e1bc921c77533ac12c7d085

  src/test/python/apache/aurora/client/commands/test_cancel_update.py e827b386323906ba827c8f1ebc7745d2303ddc23

  src/test/python/apache/aurora/client/commands/test_create.py d7c32b368605d14c55e87eb6e6cc04d83a8ef406

  src/test/python/apache/aurora/client/commands/test_diff.py b48b53d3282d25c74a8424efe15ad19493acb3a5

  src/test/python/apache/aurora/client/commands/test_hooks.py de1781eecf28c846404849c9cb3b87372fd93276

  src/test/python/apache/aurora/client/commands/test_kill.py 52732eaf6cec5fa37fd8596c3dbdc31e217dc116

  src/test/python/apache/aurora/client/commands/test_listjobs.py a7cb98f8638aac1372419cd2db8c1ce610fdf92f

  src/test/python/apache/aurora/client/commands/test_maintenance.py 20eecc03504277a2178295510efe0db5464fcfde

  src/test/python/apache/aurora/client/commands/test_restart.py 3789f3bd9ea2753070c966e0b755ab2168f7dd05

  src/test/python/apache/aurora/client/commands/test_run.py 528c3e9d93cb180eda9b2a7e0163737b95b9226e

  src/test/python/apache/aurora/client/commands/test_ssh.py 5af91336da2fc4eac268a6e351863b6f5403d060

  src/test/python/apache/aurora/client/commands/test_status.py 003af25b99ef3ec4b087df4c37e7626873cafbb8

  src/test/python/apache/aurora/client/commands/test_update.py 3f5f83e75d287984a926ccf1c4fe2ad0d362b036

  src/test/python/apache/aurora/client/commands/test_version.py cb0f4103fbcff93b506c6faf2b229ec9829f7caa

  src/test/python/apache/aurora/client/commands/util.py 0d93e76878613073812e96dcc98b95b6b0beafbe

  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1458e7d134dfe6125c27ef38ce33aee396a33e19

  src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh d157bb1d3b2ca0aa6fb391336332c71b07946fe0


Diff: https://reviews.apache.org/r/29216/diff/


Testing
-------

./pants src/test/python:all
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 


Thanks,

Maxim Khutornenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message