aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Wickman" <wick...@apache.org>
Subject Review Request 29132: get_client_version should never be allowed to run unpatched in test.
Date Wed, 17 Dec 2014 00:57:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29132/
-----------------------------------------------------------

Review request for Aurora.


Repository: aurora


Description
-------

get_client_version should never be allowed to run unpatched in test.


Diffs
-----

  src/test/python/apache/aurora/client/cli/test_help.py 1576edcaf0f59911c1c7aec42052d5ebfe41caac


Diff: https://reviews.apache.org/r/29132/diff/


Testing
-------

get_client_version tries to get the PEX-INFO of sys.argv[0], which is usually pants when running
tests (!)  if the format of PEX-INFO changes to a new version of pants (as is the case for
pants 0.0.25), then tests will start failing with an inscrutible error.  instead, just patch
get_client_version to something sensible.


Thanks,

Brian Wickman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message