aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua Cohen" <jco...@twopensource.com>
Subject Review Request 29058: Extract mechanism for determining pex version so it can be used for cases other than client version.
Date Mon, 15 Dec 2014 20:54:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29058/
-----------------------------------------------------------

Review request for Aurora, David McLaughlin, Kevin Sweeney, and Zameer Manji.


Repository: aurora


Description
-------

Extract mechanism for determining pex version so it can be used for cases other than client
version.

I'm going to use this for the soon-to-follow user agent changes.


Diffs
-----

  src/main/python/apache/aurora/client/cli/__init__.py 0e6e40a8766f80e6bc558dc08e03dc679008eb45

  src/main/python/apache/aurora/client/commands/core.py 8d9286249f176c2974d9d097597b93ce9d9a8660

  src/main/python/apache/aurora/common/BUILD 21496881eae42bff52d1f25b276b34e2dee237dd 
  src/main/python/apache/aurora/common/pex_version.py PRE-CREATION 
  src/test/python/apache/aurora/client/commands/test_version.py d3b315e156fe0ace2f2dd473e89cc991645bc084

  src/test/python/apache/aurora/common/BUILD afc0659e1917811b206004b1dc2b9edbffddaacf 
  src/test/python/apache/aurora/common/test_pex_version.py PRE-CREATION 

Diff: https://reviews.apache.org/r/29058/diff/


Testing
-------

./pants build src/test/python/apache/aurora::


Thanks,

Joshua Cohen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message