aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 28879: Make abstract decorators effective in CommandHook class
Date Fri, 12 Dec 2014 00:40:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28879/#review64827
-----------------------------------------------------------

Ship it!


Sorry, missed it.

- Maxim Khutornenko


On Dec. 9, 2014, 11:36 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28879/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2014, 11:36 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This makes the CommandHook class inherit from AbstractClass.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/command_hooks.py aa850bf941bede1d3bd8aae4811cb094ba77965f

>   src/test/python/apache/aurora/client/cli/AuroraHooks e27fcc81d6092b3b42f9a2948e3955d8f6963a14

>   src/test/python/apache/aurora/client/cli/hook_test_data/exec_error/AuroraHooks 5dc5907b9ae87632f91084e43be319c6f1b4f437

> 
> Diff: https://reviews.apache.org/r/28879/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/client/cli::
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message