aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 28198: Add an example on how to build with Docker.
Date Thu, 11 Dec 2014 19:37:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/#review64768
-----------------------------------------------------------


Sorry for the delay in responding here, thanks for opening this conversation!

One thing that stands out here is the lack of an ENTRYPOINT, which makes me wonder how this
is intended to be used.  I think it would be great if we pivoted our vagrant setup to leverage
this (to avoid repetition and continuously exercise the docker configs).  However, AFAICT
that suggests we would need multiple Dockerfiles - aurora-scheduler, aurora-observer, mesos-slave,
mesos-master.  Does that sound right to you?


examples/docker/Dockerfile
<https://reviews.apache.org/r/28198/#comment107532>

    Would it make sense for us to start with an ubuntu base image?  Our vagrant image is currently
based off ubuntu, so alignment would help prevent bifurcation.  The Dockerfile for marathon
might provide good inspiration for how to arrange this, as it has several of the same requirements:
    
    https://registry.hub.docker.com/u/mesosphere/marathon/dockerfile/
    
    Of course, i believe we still need to jump through some extra hoops for python, most of
which you've cracked already.



examples/docker/Dockerfile
<https://reviews.apache.org/r/28198/#comment107529>

    dev@aurora.incubator.apache.org



examples/docker/Dockerfile
<https://reviews.apache.org/r/28198/#comment107534>

    I think Kevin means to build with the current state of the repository the Dockerfile resides
in.  In other words, avoid the git clone entirely, and use the build commands directly.


- Bill Farner


On Dec. 11, 2014, 6:32 p.m., Tony Dong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28198/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2014, 6:32 p.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, Kevin Sweeney, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add an example on how to build with Docker.
> 
> 
> Diffs
> -----
> 
>   README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
>   examples/docker/Dockerfile PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28198/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tony Dong
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message