aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 28913: Remove SANDBOX_DELETED state.
Date Wed, 10 Dec 2014 19:41:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28913/
-----------------------------------------------------------

(Updated Dec. 10, 2014, 7:41 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Bugs: AURORA-832
    https://issues.apache.org/jira/browse/AURORA-832


Repository: aurora


Description
-------

The only questionable part for me is the change to `gc_executor.py`.  `SANDBOX_DELETED` was
used as a catch-all for an unrecognized state.  I changed this to `LOST`, for what i consider
to be lack of a better state.


Diffs
-----

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 5665c69cd7b49c3fd7345074c9f16a3b224496ab

  src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 3e3543a37137eb57db7e70b171000a254f2bb37c

  src/main/python/apache/aurora/executor/gc_executor.py 9c24771e91d55e2bb7304beaddc3abc2399c6e75

  src/test/java/org/apache/aurora/scheduler/base/JobsTest.java 56d49eaf288fd13d533f2c103059ef44ca524a63

  src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 50d387d3bac34890cf2c9715d7d307c1aa92b569

  src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 64c1b7f367898eff0902e17f655bae66a5fe61e5


Diff: https://reviews.apache.org/r/28913/diff/


Testing
-------


Thanks,

Bill Farner


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message