aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 28876: Suppressing redundant client command error messaging.
Date Tue, 09 Dec 2014 22:46:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28876/#review64453
-----------------------------------------------------------

Ship it!


Master (9926af3) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Dec. 9, 2014, 10:32 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28876/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2014, 10:32 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-965
>     https://issues.apache.org/jira/browse/AURORA-965
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added a new error type to raise when errors are logged explicitly.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py c2eb89cae536838ac4dd46b0125a248d84f6e54c

>   src/main/python/apache/aurora/client/cli/context.py ad27eb5674fb85c5d3a26a014349abdea4fa2d64

>   src/test/python/apache/aurora/client/cli/test_update.py 1f061a39279bf5ef9d4e7279016bf07e164014bb

> 
> Diff: https://reviews.apache.org/r/28876/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/client/cli:all
> 
> Vagrant before:
> 
> ```
> $ aurora2 job create devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora

>  INFO] Creating job hello
> Job creation failed due to error:
> 	Job already exists: www-data/prod/hello
> Error executing command: Job creation failed due to error:
> ```
> 
> Vagrant after:
> ```
> $ aurora2 job create devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora

>  INFO] Creating job hello
> Job creation failed due to error:
> 	Job already exists: www-data/prod/hello
> ```
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message