aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 28831: Changing the default --batch-size to 1.
Date Tue, 09 Dec 2014 18:12:58 GMT


> On Dec. 9, 2014, 2:33 a.m., Bill Farner wrote:
> > src/test/python/apache/aurora/client/cli/test_kill.py, line 134
> > <https://reviews.apache.org/r/28831/diff/1/?file=786267#file786267line134>
> >
> >     I believe this should be of the form `assert foo.mock_calls == [x]`
> >     
> >     Ditto elsewhere.

Doh, thanks for catching. I wasn't having a good day and python made it worse by allowing
an illegal assignment. 

Adding asserts revealed deeper problems with JobMonitor where scheduler calls were made in
arbitrary fashion. Mocked out JobMonitor to avoid randomness. These tests still need more
love to become truly unit rather than integration tests but I have to stop here to avoid a
complete overhaul.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28831/#review64333
-----------------------------------------------------------


On Dec. 9, 2014, 1:25 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28831/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2014, 1:25 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-961
>     https://issues.apache.org/jira/browse/AURORA-961
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Also, cleaned up kill command tests a bit.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/options.py e844cf340583b631ce194352f403bbaec71655b7

>   src/test/python/apache/aurora/client/cli/test_kill.py 1eda72af4c19831ae27733f506858e67772b2075

>   src/test/python/apache/aurora/client/cli/util.py 67d7eaa6eff4e1dbaaa485166e084812a4f04074

> 
> Diff: https://reviews.apache.org/r/28831/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/client/cli:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message