aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 28811: Improving logging experience in admin drain_hosts.
Date Mon, 08 Dec 2014 21:42:10 GMT


> On Dec. 8, 2014, 9:21 p.m., Bill Farner wrote:
> > src/main/python/apache/aurora/admin/host_maintenance.py, line 85
> > <https://reviews.apache.org/r/28811/diff/1/?file=785748#file785748line85>
> >
> >     Should this be:
> >     
> >     `self.check_if_drained(drainable_hostnames)`
> >       
> >     It seems strange that if we're watching 2 hosts, and 1 moves to DRAINED, we
keep querying for its state.
> >     
> >     Coupled with the logging change in this diff, it appears that you'll keep logging
the same hostnames over and over.
> 
> Maxim Khutornenko wrote:
>     Not sure I understand. The `not_drained_hostnames =` assignment takes care of progressively
reducing the logged hostset, so a DRAINED host will never show up in any of the subsequent
iterations.

Got it now, you probably meant `not_drained_hostnames` as a parameter there. Makes sense.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28811/#review64283
-----------------------------------------------------------


On Dec. 8, 2014, 9:13 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28811/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2014, 9:13 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-943
>     https://issues.apache.org/jira/browse/AURORA-943
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Improving logging experience in admin drain_hosts.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py bff8afd2b52fdf3977f681a73c97000a38773498

>   src/test/python/apache/aurora/admin/test_host_maintenance.py 4b8072c0349a9b0905ebb249ed97c7dfe8e8b1de

> 
> Diff: https://reviews.apache.org/r/28811/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/admin:host_maintenance
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message