aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 28811: Improving logging experience in admin drain_hosts.
Date Mon, 08 Dec 2014 21:21:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28811/#review64283
-----------------------------------------------------------



src/main/python/apache/aurora/admin/host_maintenance.py
<https://reviews.apache.org/r/28811/#comment106920>

    Can you elaborate why this is an improvement?  AFAICT the former messaging was more accurate
- we print out the hosts that you're waiting for, and will be queried/tracked.
    
    This change might make sense if we did _not_ do the initial DRAINED filtering here, and
allow the caller to report that these hosts are ready.
    
    Finally - you should consider inlining this function - there's hardly any behavior here,
and there's only one caller.



src/main/python/apache/aurora/admin/host_maintenance.py
<https://reviews.apache.org/r/28811/#comment106921>

    Should this be:
    
    `self.check_if_drained(drainable_hostnames)`
      
    It seems strange that if we're watching 2 hosts, and 1 moves to DRAINED, we keep querying
for its state.
    
    Coupled with the logging change in this diff, it appears that you'll keep logging the
same hostnames over and over.


- Bill Farner


On Dec. 8, 2014, 9:13 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28811/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2014, 9:13 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-943
>     https://issues.apache.org/jira/browse/AURORA-943
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Improving logging experience in admin drain_hosts.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py bff8afd2b52fdf3977f681a73c97000a38773498

>   src/test/python/apache/aurora/admin/test_host_maintenance.py 4b8072c0349a9b0905ebb249ed97c7dfe8e8b1de

> 
> Diff: https://reviews.apache.org/r/28811/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/admin:host_maintenance
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message