aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 28696: Use abstract decorators in CommandLine class.
Date Mon, 08 Dec 2014 17:59:47 GMT


> On Dec. 8, 2014, 5:58 p.m., Bill Farner wrote:
> > Ship It!

This is now on master:
```
$ git log -1 --abbrev-commit origin/master
commit a9e1217
Author: Zameer Manji <zmanji@twopensource.com>
Date:   Mon Dec 8 09:59:32 2014 -0800

    Use abstract decorators in CommandLine class.
    This ensures the name property and register_nouns method are implemented.

    Reviewed at https://reviews.apache.org/r/28696/
```


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28696/#review64247
-----------------------------------------------------------


On Dec. 4, 2014, 7:40 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28696/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2014, 7:40 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Use abstract decorators in CommandLine class. This ensures the name property and register_nouns
method are implemented.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8

> 
> Diff: https://reviews.apache.org/r/28696/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/client::
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message