aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 28682: Drop custom thrift doc generator in favor of the one included in thrift.
Date Fri, 05 Dec 2014 00:58:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28682/
-----------------------------------------------------------

(Updated Dec. 5, 2014, 12:58 a.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Bugs: AURORA-947
    https://issues.apache.org/jira/browse/AURORA-947


Repository: aurora


Description
-------

There's a subtle change in `buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy`
to avoid generating thermos' thrift for the scheduler.  This prevents a conflict on index.html.


Diffs (updated)
-----

  build.gradle 2699db8f9457a07d995d0707b69d10bdb171b873 
  buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy 31934f551da808951144cd474255105a9d198854

  buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy e6114cf0ec557b8d365140b5f413c69a61dc1563

  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 8955a362d8de73263c41ae0184ca384a9e12c6f2

  src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py ca2581cfc38a5873143e2ca8dc6e23b8ec389421

  src/main/resources/scheduler/assets/index.html cc62d9ea9eb5923c7bd926e1e1a45ebbeaeb0287


Diff: https://reviews.apache.org/r/28682/diff/


Testing
-------

./gradlew run, clicked around.


Thanks,

Bill Farner


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message