aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 28607: Add a caching ClusterState implementation.
Date Tue, 02 Dec 2014 23:09:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28607/#review63598
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterState.java
<https://reviews.apache.org/r/28607/#comment105873>

    minor nit: you might want to have it outside the synchronized block to further reduce
lock scope.



src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterState.java
<https://reviews.apache.org/r/28607/#comment105877>

    Would it make sense to do it conditionally, i.e.:
    ```java
    if (!Tasks.SLAVE_ASSIGNED_STATES.contains(stateChange.getNewState()) {
      Iterables.remove...
    } else {
      victims.put...
    }
    ```


- Maxim Khutornenko


On Dec. 2, 2014, 10:03 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28607/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2014, 10:03 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-121
>     https://issues.apache.org/jira/browse/AURORA-121
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a caching ClusterState implementation.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterState.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterState.java 3524dc595e7b61a531912843f90b01a87bc57cc4

>   src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModule.java 489c0bfa22aae14fbd3fd2ee9e5bd32b7c3aafa5

>   src/test/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterStateTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28607/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message