aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 28572: Minimize the state consumed when collecting preemption victims.
Date Tue, 02 Dec 2014 02:35:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28572/#review63489
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/scheduler/async/preemptor/LiveClusterState.java
<https://reviews.apache.org/r/28572/#comment105758>

    Please, drop the now unused TASK_TO_SLAVE_ID.


- Maxim Khutornenko


On Dec. 1, 2014, 8:32 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28572/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2014, 8:32 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-121
>     https://issues.apache.org/jira/browse/AURORA-121
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This should be the last step before creating a caching `ClusterState` implementation.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterState.java 4f0019a1a1272e27e600c47641bbbba05d320035

>   src/main/java/org/apache/aurora/scheduler/async/preemptor/LiveClusterState.java 9d83acc4177076411c5ce6c8304fcf75cb029597

>   src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionVictim.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java f013383b095968b0de6e917d2311c85d6afe53f7

>   src/test/java/org/apache/aurora/scheduler/async/preemptor/LiveClusterStateTest.java
8f91ff684dddc0591e71503afc0f999e508b7dbe 
> 
> Diff: https://reviews.apache.org/r/28572/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message