aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@twopensource.com>
Subject Re: Review Request 28486: Move sandbox initialization into try block.
Date Tue, 02 Dec 2014 02:14:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28486/
-----------------------------------------------------------

(Updated Dec. 1, 2014, 6:14 p.m.)


Review request for Aurora, Kevin Sweeney and Brian Wickman.


Changes
-------

+wickman 


Repository: aurora


Description
-------

Sandbox initialization is an operation that might fail and raise an exception.
By moving this into the try block the executor will return TASK_FAILED instead of crashing
when an exception is raised.


Diffs
-----

  src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2

  src/main/python/apache/aurora/executor/common/sandbox.py f47a32b3fefb4a89940b1ddc473b8316ac00df12

  src/test/python/apache/aurora/executor/BUILD 4d43e256ad131223cc1ac36a406d42a979a8a2dd 
  src/test/python/apache/aurora/executor/test_aurora_executor.py PRE-CREATION 

Diff: https://reviews.apache.org/r/28486/diff/


Testing
-------

./pants src/test/python/apache/aurora/executor::


Thanks,

Zameer Manji


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message