Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AD97310266 for ; Tue, 25 Nov 2014 06:55:33 +0000 (UTC) Received: (qmail 59727 invoked by uid 500); 25 Nov 2014 06:55:33 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 59682 invoked by uid 500); 25 Nov 2014 06:55:33 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 59671 invoked by uid 99); 25 Nov 2014 06:55:33 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Nov 2014 06:55:33 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 25 Nov 2014 06:55:09 +0000 Received: (qmail 58049 invoked by uid 99); 25 Nov 2014 06:52:37 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Nov 2014 06:52:37 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2A8371D705A; Tue, 25 Nov 2014 06:52:36 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4927358144604681556==" MIME-Version: 1.0 Subject: Re: Review Request 28361: Extract thrift into an API subproject. From: "Kevin Sweeney" To: "Bill Farner" , "Zameer Manji" , "Joshua Cohen" Cc: "Aurora" , "Kevin Sweeney" Date: Tue, 25 Nov 2014 06:52:36 -0000 Message-ID: <20141125065236.15978.61390@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/28361/ X-Sender: "Kevin Sweeney" References: <20141125063719.15977.55900@reviews.apache.org> In-Reply-To: <20141125063719.15977.55900@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============4927358144604681556== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28361/#review62942 ----------------------------------------------------------- buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy Just realized I need to define this in an afterEvaluate block for these properties to be correctly readable. - Kevin Sweeney On Nov. 24, 2014, 10:37 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28361/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2014, 10:37 p.m.) > > > Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji. > > > Bugs: AURORA-925 > https://issues.apache.org/jira/browse/AURORA-925 > > > Repository: aurora > > > Description > ------- > > Extract thrift generation into an api subproject. > > > Diffs > ----- > > .gitignore ec072d2cf7d9678c59d2f67ec3ab1fda3efd88b7 > BUILD b6d7ce983dfbb99dd7e26e547a4992a27a48ccdf > build-support/python/make-pycharm-virtualenv 8f58d4df650892aff987ccfe47a9580023b8cf63 > build-support/release/make-python-sdists e0d20a19ef1fbc129a882b6368515a3ea41bab3f > build-support/thrift/thriftw PRE-CREATION > build.gradle 7b35dedb19143b27955c12c4df94ba98ff5f6608 > buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy f233153fd093cae255c1cb6807cfec6590ba36f9 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy PRE-CREATION > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy PRE-CREATION > gradle/wrapper/gradle-wrapper.properties b04300260fd3975ec98a1a1d87b57025e7904c2f > settings.gradle 3e9cbfe6e6836f70fb9164f80973f3ebb813ef98 > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 4b9281590a9eeb8a8b571b909fd507259abfac44 > src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java c072010eddddd5a1856a05fa7e6c87b25c073059 > src/main/python/apache/aurora/admin/BUILD 9441e121bf4ea88a7ae286f8cd1cbd0c0ac89e06 > src/main/python/apache/aurora/client/BUILD 48566d99f432e6eb94d1bfdb18277205fd7bb9d8 > src/main/python/apache/aurora/client/api/BUILD 6d2a1bfe8531d800be651ec00518fc5b07a53474 > src/main/python/apache/aurora/client/cli/BUILD e6627a8a3c501292fdd31ec384320870db702bc2 > src/main/python/apache/aurora/client/commands/BUILD d146015d70715142618f2653538aca6beb83c1fc > src/main/python/apache/aurora/client/hooks/BUILD f46cf650d9b471d08ed2b76652bca5d429f955ee > src/main/python/apache/aurora/common/BUILD 02ec17ce35c6632df204ea4d1d12e61daf30dd1f > src/main/python/apache/aurora/common/auth/BUILD c26d117122d17b2228b637441ce0aa564f5a8a3e > src/main/python/apache/aurora/config/BUILD fa40ebdfdecae3eb13878d6f172a591c16507530 > src/main/python/apache/aurora/config/schema/BUILD 157c141bdf968666f31452784967de2a640d1815 > src/main/python/apache/aurora/executor/BUILD ca4193d31e3e3a71fa45f918058fba40fc911487 > src/main/python/apache/aurora/executor/common/BUILD d33e14b1cf7be7d115c7fe7741d52896f02f3aed > src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d6bb5a120bb6368305ab52d253d25ad2bcfb3e8b > src/main/python/apache/thermos/bin/BUILD 34e2b3fe1d1a49cc51db8f61339a21ff8e03e0f4 > src/main/python/apache/thermos/common/BUILD 918800b4ccb7bef61249d488ca8a4255168311bb > src/main/python/apache/thermos/core/BUILD f362acdc395f1e479bcaf4bc063456abb1fdb0e2 > src/main/python/apache/thermos/monitoring/BUILD 0dad47e6337b7db33dca793f0324892d61e3433a > src/main/python/apache/thermos/observer/BUILD b07db90906a06779f5369158469651425fefa1a3 > src/main/python/apache/thermos/testing/BUILD b96c166e9bc529b783071b5d37b78779a36d06c3 > src/main/resources/scheduler/assets/scheduler/index.html f4ca07166aee21b8e6b7d3da82454e1b9b132f59 > src/main/thrift/org/apache/aurora/gen/BUILD > src/main/thrift/org/apache/aurora/gen/api.thrift > src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift > src/main/thrift/org/apache/aurora/gen/storage.thrift > src/main/thrift/org/apache/aurora/gen/test.thrift > src/main/thrift/org/apache/thermos/BUILD > src/main/thrift/org/apache/thermos/thermos_internal.thrift > src/test/python/apache/aurora/admin/BUILD 101aaa068f2a134f0e846359dc11c7a0ccc28dbb > src/test/python/apache/aurora/client/api/BUILD f46ef695decd9b91112b9c933f6220efaa5a0bd3 > src/test/python/apache/aurora/client/commands/BUILD 000eafa95802d6cc835cae7c6f68016645dfe0f1 > src/test/python/apache/aurora/common/BUILD 3933c4616e1df667e7b2ce79e1a6df4c62ca73cf > src/test/python/apache/aurora/config/BUILD 551595ec6268046817cb1f183d8b0c0af03f5cba > src/test/python/apache/aurora/executor/BUILD 23a93fdb50c2492d4d8f4613796ff1723e3659fa > src/test/python/apache/aurora/executor/common/BUILD 318e66d477bbf75d5e36ffe4bc70294da34b4965 > > Diff: https://reviews.apache.org/r/28361/diff/ > > > Testing > ------- > > ./gradlew -Pq build > ./pants src/test/python:all > > > Thanks, > > Kevin Sweeney > > --===============4927358144604681556==--