Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============6742441660520534851=="
MIME-Version: 1.0
Subject: Re: Review Request 28411: Adding quota check into replaceCronTemplate
 rpc.
From: "Aurora ReviewBot" <wfarner@apache.org>
To: "Bill Farner" <wfarner@apache.org>
Cc: "Aurora ReviewBot" <wfarner@apache.org>,
 "Aurora" <reviews@aurora.incubator.apache.org>,
 "Maxim Khutornenko" <maxim@apache.org>
Date: Mon, 24 Nov 2014 21:47:16 -0000
Message-ID: <20141124214716.15977.15136@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Aurora ReviewBot" <noreply@reviews.apache.org>
References: <20141124212729.15977.89558@reviews.apache.org>
In-Reply-To: <20141124212729.15977.89558@reviews.apache.org>
Reply-To: "Aurora ReviewBot" <wfarner@apache.org>

--===============6742441660520534851==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28411/#review62878
-----------------------------------------------------------


Master (9514a63) is red with this patch.
  ./build-support/jenkins/build.sh

  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/python_builder.py", line 43, in build
    debug=debug).run()
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py", line 88, in run
    rv = self._run_tests([target], stdout, stderr)
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py", line 316, in _run_tests
    with self._test_runner(targets, stdout, stderr) as (pex, test_args):
  File "/usr/lib/python2.7/contextlib.py", line 17, in __enter__
    return self.gen.next()
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py", line 295, in _test_runner
    builder = chroot.dump()
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/python_chroot.py", line 191, in dump
    conn_timeout=self._conn_timeout)
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/resolver.py", line 100, in resolve_multi
    platform=platform)
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pex/resolver.py", line 101, in resolve
    raise Unsatisfiable('Cannot satisfy requirements: %s' % requirement_set[requirement.key])
Unsatisfiable: Cannot satisfy requirements: [Requirement.parse('twitter.common.metrics==0.3.2')]


Usage: 
  pants build (options) [spec] (build args)
  pants build (options) [spec]... -- (build args)

Options:
  --version             show program's version number and exit
  --no-pantsrc          Specifies that pantsrc files should be ignored.
  --log-exit            Log an exit message on success or failure.
  -t CONN_TIMEOUT, --timeout=CONN_TIMEOUT
                        Number of seconds to wait for http connections.
  -i INTERPRETERS, --interpreter=INTERPRETERS
                        Constrain what Python interpreters to use.  Uses
                        Requirement format from pkg_resources, e.g.
                        'CPython>=2.6,<3' or 'PyPy'. By default, no
                        constraints are used.  Multiple constraints may be
                        added.  They will be ORed together.
  -v, --verbose         Show verbose output.
  -f, --fast            Run tests in a single chroot.

Builds the specified Python target(s). Use ./pants goal for JVM and other
targets.


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Nov. 24, 2014, 9:27 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28411/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 9:27 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-946
>     https://issues.apache.org/jira/browse/AURORA-946
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Merged scheduleCronJob and replaceCronTemplate implementations. 
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a5e869fc52ab6c4c28e6965585b015440f448f59 
>   src/main/thrift/org/apache/aurora/gen/api.thrift b91fca9383891af15477a6f6ef7c407bfa125303 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java de5f21a084109e5f31a7e5fca1b8ee265e30b893 
> 
> Diff: https://reviews.apache.org/r/28411/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> vagrant@vagrant-ubuntu-trusty-64:~$ aurora update  devcluster/vagrant/test/cron_hello_world2 aurora/examples/jobs/cron_hello_world.aurora 
> WARNING: update is an aurora clientv1 command which will be deprecated soon
> To run this command using clientv2, use 'aurora job update devcluster/vagrant/test/cron_hello_world2 aurora/examples/jobs/cron_hello_world.aurora --health-check-interval-seconds=3'
>  INFO] Updating job: cron_hello_world2
>  INFO] Response from scheduler: ERROR (message: Aborting update without rollback! Fatal error: Response from scheduler: INVALID_REQUEST (message: Insufficient resource quota: CPU quota exceeded by 1.00 core(s); RAM quota exceeded by 1024.00 MB; DISK quota exceeded by 1024.00 MB))
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


--===============6742441660520534851==--