Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C2E0517EA0 for ; Sat, 22 Nov 2014 01:53:50 +0000 (UTC) Received: (qmail 10592 invoked by uid 500); 22 Nov 2014 01:53:50 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 10550 invoked by uid 500); 22 Nov 2014 01:53:50 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 10539 invoked by uid 99); 22 Nov 2014 01:53:50 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Nov 2014 01:53:50 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Sat, 22 Nov 2014 01:53:27 +0000 Received: (qmail 10035 invoked by uid 99); 22 Nov 2014 01:53:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Nov 2014 01:53:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 735741DB13E; Sat, 22 Nov 2014 01:53:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8236997422677358657==" MIME-Version: 1.0 Subject: Re: Review Request 28360: Make PreemptorImpl package private. From: "Aurora ReviewBot" To: "Zameer Manji" , "Kevin Sweeney" Cc: "Bill Farner" , "Aurora ReviewBot" , "Aurora" Date: Sat, 22 Nov 2014 01:53:24 -0000 Message-ID: <20141122015324.15353.8088@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/28360/ X-Sender: "Aurora ReviewBot" References: <20141122013423.15325.46341@reviews.apache.org> In-Reply-To: <20141122013423.15325.46341@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============8236997422677358657== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28360/#review62717 ----------------------------------------------------------- Ship it! Master (a431b1d) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 22, 2014, 1:34 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28360/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2014, 1:34 a.m.) > > > Review request for Aurora, Kevin Sweeney and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > Make PreemptorImpl package private. This is a pure refactor, moving PreemptorImpl out of Preemptor. The detla looks much larger than it is. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/async/preemptor/Preemptor.java 767e6010c28158860e3ac5710158466fe1925cad > src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModule.java bc96b6713b7d4624ae4d0730c5b822ca9d6001d0 > src/main/java/org/apache/aurora/scheduler/storage/Storage.java 42233e53621a08ca10226aeea2b27c66bdae8123 > src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java 65581ba03583dcfa931f2aa412c8616d97c44c41 > > Diff: https://reviews.apache.org/r/28360/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > > --===============8236997422677358657==--