Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============4931451645195686447=="
MIME-Version: 1.0
Subject: Re: Review Request 28350: Add cron replace command.
From: "Kevin Sweeney" <kevints@apache.org>
To: "Bill Farner" <wfarner@apache.org>,
 "David McLaughlin" <david@dmclaughlin.com>
Cc: "Aurora" <reviews@aurora.incubator.apache.org>,
 "Maxim Khutornenko" <maxim@apache.org>, "Kevin Sweeney" <kevints@apache.org>
Date: Sat, 22 Nov 2014 01:19:08 -0000
Message-ID: <20141122011908.15353.31631@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Kevin Sweeney" <noreply@reviews.apache.org>
References: <20141121232614.16171.59345@reviews.apache.org>
In-Reply-To: <20141121232614.16171.59345@reviews.apache.org>
Reply-To: "Kevin Sweeney" <kevints@apache.org>

--===============4931451645195686447==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Nov. 21, 2014, 3:26 p.m., Kevin Sweeney wrote:
> > docs/cron-jobs.md, line 89
> > <https://reviews.apache.org/r/28350/diff/1/?file=772861#file772861line89>
> >
> >     Hold on a sec - why do we have this and cron schedule (see above)?
> 
> Maxim Khutornenko wrote:
>     The "cron replace" is an atomic convenience command for "cron deschedule" + "cron schedule". It finalizes the cron/service split:
>     job create <> cron schedule
>     job killall <> cron deschedule (with caveat that active tasks are not killed)
>     job update <> cron replace
> 
> Kevin Sweeney wrote:
>     cron schedule does both "job create" and "job update"
> 
> Maxim Khutornenko wrote:
>     What..? I completely forgot that scheduleCronJob actually acts as "upsert". Should we move the "update" functionality from it in favor of replaceCronTemplate and have our client `cron` commands consistent with `job` commands though? I can argue both ways. Any thoughts?

I was completely surprised to learn that when I was writing this document as well.

I'm in favor of leaving the existing behavior as-is and removing any unused endpoints.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28350/#review62676
-----------------------------------------------------------


On Nov. 21, 2014, 4:54 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28350/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2014, 4:54 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-921
>     https://issues.apache.org/jira/browse/AURORA-921
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implementing "aurora cron replace" command to close the functionality gap that will be created with client updater removal.
> 
> 
> Diffs
> -----
> 
>   docs/clientv2.md 6e69af3837f63321e273f1df7b0f5a1c07505cc7 
>   docs/cron-jobs.md 7d04bcd3776bfd85f14e4398c4bc57dfbbdbcc72 
>   src/main/python/apache/aurora/client/api/__init__.py d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59 
>   src/main/python/apache/aurora/client/cli/cron.py cfd957cb99fb1c0bff04f0c91969a66faaf3b6f2 
>   src/main/python/apache/aurora/client/cli/update.py 12774af8bcd1c953fdbc799b0a142c27407d69f5 
>   src/test/python/apache/aurora/client/api/test_api.py 1f4e9fe9111ac88726d7c45b699b3b91438448b6 
>   src/test/python/apache/aurora/client/cli/test_cron.py c748212febf5867f5f7cc54e34bf91a8890d9999 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 7637352feea6b07408256158814c05bc17ec14f3 
>   src/test/python/apache/aurora/client/cli/util.py 0ec74e675aaabc7ac0cb28e02f5b8534570b7a49 
> 
> Diff: https://reviews.apache.org/r/28350/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python:all
> 
> tested in vagrant as well
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


--===============4931451645195686447==--