Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 210C817A37 for ; Fri, 21 Nov 2014 23:04:56 +0000 (UTC) Received: (qmail 21784 invoked by uid 500); 21 Nov 2014 23:04:56 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 21746 invoked by uid 500); 21 Nov 2014 23:04:56 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 21232 invoked by uid 99); 21 Nov 2014 23:04:55 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Nov 2014 23:04:55 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 21 Nov 2014 23:04:33 +0000 Received: (qmail 17574 invoked by uid 99); 21 Nov 2014 23:04:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Nov 2014 23:04:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D7FA61DB13E; Fri, 21 Nov 2014 23:04:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6172977978410212933==" MIME-Version: 1.0 Subject: Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks. From: "Aurora ReviewBot" To: "Bill Farner" , "Maxim Khutornenko" Cc: "Aurora ReviewBot" , "Aurora" , "Zameer Manji" Date: Fri, 21 Nov 2014 23:04:29 -0000 Message-ID: <20141121230429.15353.35765@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/28193/ X-Sender: "Aurora ReviewBot" References: <20141121225000.15325.47304@reviews.apache.org> In-Reply-To: <20141121225000.15325.47304@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============6172977978410212933== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28193/#review62673 ----------------------------------------------------------- Ship it! Master (ecc3fbc) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 21, 2014, 10:50 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28193/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2014, 10:50 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-928 > https://issues.apache.org/jira/browse/AURORA-928 > > > Repository: aurora > > > Description > ------- > > Mesos rejects tasks and executors that are zero sized. This patch reconfigures Aurora to ensure no zero sized tasks and executors are created. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ed60447c798a97daceda4a3bba6ee9bcdcaedd0f > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 40b652c679d8e340f585e28cbed066335d9d760d > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java bb227fd86f7c4c692f6ae2aef1c15a94913354b7 > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064 > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 953c1edb6802d8983ab324aa56361e5c8fbe2e68 > > Diff: https://reviews.apache.org/r/28193/diff/ > > > Testing > ------- > > ./gradlew clean build -Pq > > > Thanks, > > Zameer Manji > > --===============6172977978410212933==--