Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2412311CA4 for ; Fri, 21 Nov 2014 19:42:49 +0000 (UTC) Received: (qmail 78476 invoked by uid 500); 21 Nov 2014 19:42:49 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 78430 invoked by uid 500); 21 Nov 2014 19:42:49 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 78417 invoked by uid 99); 21 Nov 2014 19:42:48 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Nov 2014 19:42:48 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 21 Nov 2014 19:42:47 +0000 Received: (qmail 76928 invoked by uid 99); 21 Nov 2014 19:42:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Nov 2014 19:42:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5B8C61FB75A; Fri, 21 Nov 2014 19:42:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6958030060279053136==" MIME-Version: 1.0 Subject: Re: Review Request 28310: Extract a cluster state abstraction from PreemptorImpl. From: "Bill Farner" To: "Maxim Khutornenko" , "Zameer Manji" Cc: "Joshua Cohen" , "Bill Farner" , "Aurora" , "Aurora ReviewBot" Date: Fri, 21 Nov 2014 19:42:26 -0000 Message-ID: <20141121194226.16171.81145@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/28310/ X-Sender: "Bill Farner" References: <20141121182820.15325.21248@reviews.apache.org> In-Reply-To: <20141121182820.15325.21248@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============6958030060279053136== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28310/ ----------------------------------------------------------- (Updated Nov. 21, 2014, 7:42 p.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Changes ------- Fixed TODO comment. Bugs: AURORA-121 https://issues.apache.org/jira/browse/AURORA-121 Repository: aurora Description ------- This is to pull out the bits that will be cached for performance improvements. Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/app/AppModule.java 19bf162586b90329e764cacf992df37ca68b0dc0 src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 4e37f4c9c8d4cde477a96a9b8cca7a075f170919 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 97d5d13fcb686c7199ccf92ddab04931d6d5ab57 src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java f247ccfb115d4daa10fd4ca46750f708a093791b src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterState.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/async/preemptor/LiveClusterState.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModule.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 962aff8f4fa590935773c9fe90b1a6f59bc1c51f src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 69108cf93e8478b54b0292c27ff56074448ec793 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 17f2d77bd1a143a9388ff1f52fa8edfcdfe08d91 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 012804a72fddb3e05f01d7e556cd577c07614ede src/test/java/org/apache/aurora/scheduler/async/preemptor/LiveClusterStateTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModuleTest.java PRE-CREATION Diff: https://reviews.apache.org/r/28310/diff/ Testing ------- Thanks, Bill Farner --===============6958030060279053136==--