Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2EDCE10F8B for ; Thu, 20 Nov 2014 20:06:20 +0000 (UTC) Received: (qmail 16965 invoked by uid 500); 20 Nov 2014 20:06:20 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 16920 invoked by uid 500); 20 Nov 2014 20:06:20 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 16908 invoked by uid 99); 20 Nov 2014 20:06:19 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Nov 2014 20:06:19 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 20 Nov 2014 20:05:56 +0000 Received: (qmail 16726 invoked by uid 99); 20 Nov 2014 20:05:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Nov 2014 20:05:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8632A117315; Thu, 20 Nov 2014 20:05:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7540278619454902206==" MIME-Version: 1.0 Subject: Re: Review Request 27705: Adding instrumentation into the scheduling pipeline. From: "Maxim Khutornenko" To: "Bill Farner" , "Zameer Manji" Cc: "Aurora" , "Maxim Khutornenko" Date: Thu, 20 Nov 2014 20:05:53 -0000 Message-ID: <20141120200553.15325.7118@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/27705/ X-Sender: "Maxim Khutornenko" References: <20141120030102.15353.63269@reviews.apache.org> In-Reply-To: <20141120030102.15353.63269@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============7540278619454902206== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review62403 ----------------------------------------------------------- @ReviewBot retry - Maxim Khutornenko On Nov. 20, 2014, 3:01 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27705/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2014, 3:01 a.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-914 > https://issues.apache.org/jira/browse/AURORA-914 > > > Repository: aurora > > > Description > ------- > > Adding @Timed to trace scheduling latencies and Veto counters per type. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/TaskVars.java cf8f7584afee758c527798914181049051aef0d8 > src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java d2682cd910d248c897e691bcb4c8a3a6f1aec2d2 > src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java f247ccfb115d4daa10fd4ca46750f708a093791b > src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 4821a7890b77ccb04c10bee6d8b4b9e7216940cc > src/main/java/org/apache/aurora/scheduler/filter/ConstraintMatcher.java cc8c5b81baf0cf05d7ac04f69ad2834fa9438aac > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 723e7ab70b8bfd930154dcce385cd1e1d599cf9f > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java cf3bb644008274672c77753b94f4d50c99a1a49b > src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 87203690f09456ac1ca5e9da2b82826d60cbd723 > src/main/java/org/apache/aurora/scheduler/stats/CachedCounters.java aaedb3b5ec2cb27550449435efa8f335c6a9baad > src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 12ea4c67350c2992f59bacd21a99d1413b60b757 > src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java d408ec0f7781f65d5b5f215eced5d6255e53b0dd > src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java d1a70661122802ecfdd8efa2ced567685c08995f > src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java b60b004adbd6753ec6fef125fd70286be5071c56 > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 168290af9f84750e66dca69cf056dacb5f38aaa3 > > Diff: https://reviews.apache.org/r/27705/diff/ > > > Testing > ------- > > ./gradlew -Pq build > Verified new stats in vagrant. > > > Thanks, > > Maxim Khutornenko > > --===============7540278619454902206==--