Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 55EE51040E for ; Wed, 19 Nov 2014 22:51:54 +0000 (UTC) Received: (qmail 964 invoked by uid 500); 19 Nov 2014 22:51:53 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 923 invoked by uid 500); 19 Nov 2014 22:51:53 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 908 invoked by uid 99); 19 Nov 2014 22:51:52 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Nov 2014 22:51:52 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 19 Nov 2014 22:51:51 +0000 Received: (qmail 97381 invoked by uid 99); 19 Nov 2014 22:51:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Nov 2014 22:51:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6A2D5116C1B; Wed, 19 Nov 2014 22:51:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4603578723756504071==" MIME-Version: 1.0 Subject: Re: Review Request 27705: Adding instrumentation into the scheduling pipeline. From: "Bill Farner" To: "Bill Farner" , "Zameer Manji" Cc: "Aurora" , "Maxim Khutornenko" Date: Wed, 19 Nov 2014 22:51:30 -0000 Message-ID: <20141119225130.15353.13480@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/27705/ X-Sender: "Bill Farner" References: <20141115001551.1250.48475@reviews.apache.org> In-Reply-To: <20141115001551.1250.48475@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============4603578723756504071== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review62256 ----------------------------------------------------------- src/main/java/org/apache/aurora/scheduler/TaskVars.java This should be the only dynamic one, right? Rack/host limit? Value constraints can be considered static. src/main/java/org/apache/aurora/scheduler/TaskVars.java I don't have strong data to back this up, but i'm concerned about the performance impact here. In a large/busy cluster, this could be invoked O(100k) times per second. Can you avoid the Set creation? Maybe instead just loop and use two flags? To combat this, we really need to move the nearest fit/miss calculation to the publisher end (which would, unfortunately, break these stats). For now, i think it makes sense to merely be cognizant of the call frequency. - Bill Farner On Nov. 15, 2014, 12:15 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27705/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2014, 12:15 a.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-914 > https://issues.apache.org/jira/browse/AURORA-914 > > > Repository: aurora > > > Description > ------- > > Adding @Timed to trace scheduling latencies and Veto counters per type. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/TaskVars.java cf8f7584afee758c527798914181049051aef0d8 > src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java d2682cd910d248c897e691bcb4c8a3a6f1aec2d2 > src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 6bfa3ac425ed3045fa60d1b0ca547e9bf3cde37a > src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 4821a7890b77ccb04c10bee6d8b4b9e7216940cc > src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 3839083f27ca5d4b93406152559b58b04e912a10 > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java c1c5f26723f1eac3000e09e061b4582f922fded6 > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java cc6b53b3265253f76c1e954c0108aa5936f5cc36 > src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 87203690f09456ac1ca5e9da2b82826d60cbd723 > src/main/java/org/apache/aurora/scheduler/stats/CachedCounters.java aaedb3b5ec2cb27550449435efa8f335c6a9baad > src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 12ea4c67350c2992f59bacd21a99d1413b60b757 > src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 94f0a179b786649775899f855f7c1a0caab7290f > src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java e113eba1f304279b5ee3d70db1d1ea558efd63ac > src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java b60b004adbd6753ec6fef125fd70286be5071c56 > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 608903268a0a0d67711bfdc81d2e5b29c335ead2 > > Diff: https://reviews.apache.org/r/27705/diff/ > > > Testing > ------- > > ./gradlew -Pq build > Verified new stats in vagrant. > > > Thanks, > > Maxim Khutornenko > > --===============4603578723756504071==--