Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5FF6B10E57 for ; Wed, 19 Nov 2014 20:50:43 +0000 (UTC) Received: (qmail 51541 invoked by uid 500); 19 Nov 2014 20:50:43 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 51502 invoked by uid 500); 19 Nov 2014 20:50:43 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 51491 invoked by uid 99); 19 Nov 2014 20:50:42 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Nov 2014 20:50:42 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 19 Nov 2014 20:50:41 +0000 Received: (qmail 49488 invoked by uid 99); 19 Nov 2014 20:50:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Nov 2014 20:50:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8768E116D86; Wed, 19 Nov 2014 20:50:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6653337216308908064==" MIME-Version: 1.0 Subject: Re: Review Request 28250: Fix test_version to use explicit injection points. From: "Zameer Manji" To: "Maxim Khutornenko" , "Zameer Manji" , "David McLaughlin" Cc: "Aurora" , "Kevin Sweeney" Date: Wed, 19 Nov 2014 20:50:20 -0000 Message-ID: <20141119205020.15325.58903@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Zameer Manji" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/28250/ X-Sender: "Zameer Manji" References: <20141119204447.15325.58427@reviews.apache.org> In-Reply-To: <20141119204447.15325.58427@reviews.apache.org> Reply-To: "Zameer Manji" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============6653337216308908064== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28250/#review62222 ----------------------------------------------------------- src/main/python/apache/aurora/client/commands/core.py Why was the logic moved out of here? - Zameer Manji On Nov. 19, 2014, 12:44 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28250/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 12:44 p.m.) > > > Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Zameer Manji. > > > Bugs: AURORA-938 > https://issues.apache.org/jira/browse/AURORA-938 > > > Repository: aurora > > > Description > ------- > > Fix test_version to use explicit injection points. > > > Diffs > ----- > > src/main/python/apache/aurora/client/commands/core.py 852b6b1ba479a8781133f2331fb75f8122a36855 > src/test/python/apache/aurora/client/commands/test_version.py 5c3c45a769aeec2ffb2c2bd3d8d937476c9abd12 > > Diff: https://reviews.apache.org/r/28250/diff/ > > > Testing > ------- > > ./pants src/test/python:all > ./pants src/main/python/apache/aurora/client/bin:aurora_client > dist/aurora_client.pex version > > > Thanks, > > Kevin Sweeney > > --===============6653337216308908064==--