Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0D2F110A9A for ; Tue, 18 Nov 2014 00:44:42 +0000 (UTC) Received: (qmail 26701 invoked by uid 500); 18 Nov 2014 00:44:41 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 26659 invoked by uid 500); 18 Nov 2014 00:44:41 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 26648 invoked by uid 99); 18 Nov 2014 00:44:41 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Nov 2014 00:44:41 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 18 Nov 2014 00:44:40 +0000 Received: (qmail 26245 invoked by uid 99); 18 Nov 2014 00:44:16 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Nov 2014 00:44:16 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9B814116601; Tue, 18 Nov 2014 00:44:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3003933034335003274==" MIME-Version: 1.0 Subject: Re: Review Request 28140: Drop argparse dependency; it's part of python 2.7 From: "Aurora ReviewBot" To: "Kevin Sweeney" , "David McLaughlin" Cc: "Aurora ReviewBot" , "Aurora" , "Joshua Cohen" Date: Tue, 18 Nov 2014 00:44:15 -0000 Message-ID: <20141118004415.24716.35638@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/28140/ X-Sender: "Aurora ReviewBot" References: <20141118002946.24717.75557@reviews.apache.org> In-Reply-To: <20141118002946.24717.75557@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============3003933034335003274== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28140/#review61843 ----------------------------------------------------------- Master (c44aa5c) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 18, 2014, 12:29 a.m., Joshua Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28140/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2014, 12:29 a.m.) > > > Review request for Aurora, David McLaughlin and Kevin Sweeney. > > > Bugs: AURORA-891 > https://issues.apache.org/jira/browse/AURORA-891 > > > Repository: aurora > > > Description > ------- > > Drop argparse dependency; it's part of python 2.7 > > > Diffs > ----- > > 3rdparty/python/BUILD 63ae77f4632db158109e8d562488ce4e84da0438 > src/main/python/apache/aurora/client/cli/BUILD 995570325bbb09ecbcc2ace5d223760c5d49367f > > Diff: https://reviews.apache.org/r/28140/diff/ > > > Testing > ------- > > ./pants build src/test/python:all > bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh > > > Thanks, > > Joshua Cohen > > --===============3003933034335003274==--