Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A39C31075A for ; Fri, 14 Nov 2014 01:40:16 +0000 (UTC) Received: (qmail 47982 invoked by uid 500); 14 Nov 2014 01:40:16 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 47939 invoked by uid 500); 14 Nov 2014 01:40:16 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 47928 invoked by uid 99); 14 Nov 2014 01:40:15 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Nov 2014 01:40:15 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 14 Nov 2014 01:40:14 +0000 Received: (qmail 42567 invoked by uid 99); 14 Nov 2014 01:38:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Nov 2014 01:38:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 61F941FB630; Fri, 14 Nov 2014 01:38:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3154519043576135936==" MIME-Version: 1.0 Subject: Re: Review Request 28021: Remove dependency on commons-lang. From: "Aurora ReviewBot" To: "Kevin Sweeney" , "Joshua Cohen" Cc: "Aurora ReviewBot" , "Aurora" , "Zameer Manji" Date: Fri, 14 Nov 2014 01:38:42 -0000 Message-ID: <20141114013842.11644.40584@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/28021/ X-Sender: "Aurora ReviewBot" References: <20141114010702.11644.34777@reviews.apache.org> In-Reply-To: <20141114010702.11644.34777@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============3154519043576135936== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28021/#review61368 ----------------------------------------------------------- Master (254e175) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 14, 2014, 1:07 a.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28021/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2014, 1:07 a.m.) > > > Review request for Aurora, Joshua Cohen and Kevin Sweeney. > > > Repository: aurora > > > Description > ------- > > Remove dependency on commons-lang. > > > Diffs > ----- > > build.gradle 3237f8dfa3e7d4249a388042dba840a939d513b3 > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 3661f8487985f631e3ea437fe6430e0296376a9e > src/main/java/org/apache/aurora/scheduler/configuration/SanitizedConfiguration.java 4eb4437b91906ae191dd105474e84ba5f40cf52e > src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 48b403e155684861ec0307a61ccb0775cdb57a32 > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 37176237fac336413267f3c8bb4e1b9a6255150c > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a43e5d7748c22d60f56f03a8a3d52949faebeff2 > > Diff: https://reviews.apache.org/r/28021/diff/ > > > Testing > ------- > > ./gradlew clean build -Pq > > > Thanks, > > Zameer Manji > > --===============3154519043576135936==--