Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E87F5CB9E for ; Thu, 13 Nov 2014 02:52:23 +0000 (UTC) Received: (qmail 70556 invoked by uid 500); 13 Nov 2014 02:50:36 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 70524 invoked by uid 500); 13 Nov 2014 02:50:36 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 70319 invoked by uid 99); 13 Nov 2014 02:50:35 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Nov 2014 02:50:35 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 13 Nov 2014 02:50:12 +0000 Received: (qmail 27412 invoked by uid 99); 13 Nov 2014 02:07:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Nov 2014 02:07:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 97C0211614B; Thu, 13 Nov 2014 02:07:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3072875843183021450==" MIME-Version: 1.0 Subject: Re: Review Request 27947: Setting the max thread limit on AsyncEventBus. From: "Bill Farner" To: "Bill Farner" Cc: "Aurora" , "Maxim Khutornenko" Date: Thu, 13 Nov 2014 02:07:45 -0000 Message-ID: <20141113020745.9703.50857@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/27947/ X-Sender: "Bill Farner" References: <20141113011237.17177.1983@reviews.apache.org> In-Reply-To: <20141113011237.17177.1983@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============3072875843183021450== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27947/#review61178 ----------------------------------------------------------- src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java Given that we're moving from an effective "same thread executor" to async, i think we can get by with fewer knobs for now. How about: Executors.newFixedThreadPool( PUBSUB_WORKER_THREADS.get(), ... - Bill Farner On Nov. 13, 2014, 1:12 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27947/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2014, 1:12 a.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-926 > https://issues.apache.org/jira/browse/AURORA-926 > > > Repository: aurora > > > Description > ------- > > Setting the max thread limit on AsyncEventBus. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 24cd750c676a280d1cc953c96df126f19fc478f2 > > Diff: https://reviews.apache.org/r/27947/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > > --===============3072875843183021450==--