Return-Path: 
 <reviews-return-5814-apmail-aurora-reviews-archive=aurora.apache.org@aurora.incubator.apache.org>
X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org
Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 2D82B17D7D
	for <apmail-aurora-reviews-archive@minotaur.apache.org>;
 Tue, 11 Nov 2014 23:53:39 +0000 (UTC)
Received: (qmail 42143 invoked by uid 500); 11 Nov 2014 23:53:39 -0000
Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org
Received: (qmail 42100 invoked by uid 500); 11 Nov 2014 23:53:39 -0000
Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@aurora.incubator.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@aurora.incubator.apache.org>
List-Post: <mailto:reviews@aurora.incubator.apache.org>
List-Id: <reviews.aurora.incubator.apache.org>
Reply-To: reviews@aurora.incubator.apache.org
Delivered-To: mailing list reviews@aurora.incubator.apache.org
Received: (qmail 42089 invoked by uid 99); 11 Nov 2014 23:53:38 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Nov 2014 23:53:38 +0000
X-ASF-Spam-Status: No, hits=-1998.4 required=5.0
	tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3)
    by apache.org (qpsmtpd/0.29) with SMTP; Tue, 11 Nov 2014 23:53:37 +0000
Received: (qmail 41088 invoked by uid 99); 11 Nov 2014 23:53:17 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Nov 2014 23:53:17 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id B3A0A1DFEA1;
	Tue, 11 Nov 2014 23:53:19 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============0751530891671468485=="
MIME-Version: 1.0
Subject: Re: Review Request 27892: Fixes for the make pycharm script:
From: "Aurora ReviewBot" <wfarner@apache.org>
To: "Bill Farner" <wfarner@apache.org>, "Kevin Sweeney" <kevints@apache.org>
Cc: "Aurora ReviewBot" <wfarner@apache.org>,
 "Aurora" <reviews@aurora.incubator.apache.org>,
 "Joshua Cohen" <jcohen@twopensource.com>
Date: Tue, 11 Nov 2014 23:53:19 -0000
Message-ID: <20141111235319.17177.98906@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Aurora ReviewBot" <noreply@reviews.apache.org>
X-ReviewGroup: Aurora
X-ReviewRequest-URL: https://reviews.apache.org/r/27892/
X-Sender: "Aurora ReviewBot" <noreply@reviews.apache.org>
References: <20141111231113.19819.43084@reviews.apache.org>
In-Reply-To: <20141111231113.19819.43084@reviews.apache.org>
Reply-To: "Aurora ReviewBot" <wfarner@apache.org>
X-ReviewRequest-Repository: aurora
X-Virus-Checked: Checked by ClamAV on apache.org

--===============0751530891671468485==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27892/#review60898
-----------------------------------------------------------

Ship it!


Master (0774c4e) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Nov. 11, 2014, 11:11 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27892/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2014, 11:11 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fixes for the make pycharm script:
> 
> 1. Escape $'s
> 2. Use root directory name as project name
> 3. Exclude some noisy directories
> 
> 
> Diffs
> -----
> 
>   build-support/python/make-pycharm-virtualenv 316ead7c92e0510cd53958f419686e902dc34204 
> 
> Diff: https://reviews.apache.org/r/27892/diff/
> 
> 
> Testing
> -------
> 
> $ cat .idea/incubator-aurora.iml 
> <?xml version="1.0" encoding="UTF-8"?>
> <module type="PYTHON_MODULE" version="4">
>   <component name="NewModuleRootManager">
>     <content url="file://$MODULE_DIR$">
>       <sourceFolder url="file://$MODULE_DIR$/src/main/python" isTestSource="false" />
>       <excludeFolder url="file://$MODULE_DIR$/.pants.d" />
>       <excludeFolder url="file://$MODULE_DIR$/dist" />
>       <excludeFolder url="file://$MODULE_DIR$/out" />
>     </content>
>     <orderEntry type="inheritedJdk" />
>     <orderEntry type="sourceFolder" forTests="false" />
>   </component>
>   <component name="TestRunnerService">
>     <option name="projectConfiguration" value="py.test" />
>     <option name="PROJECT_TEST_RUNNER" value="py.test" />
>   </component>
> </module>
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


--===============0751530891671468485==--