Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A1F9E17A4F for ; Tue, 11 Nov 2014 22:51:25 +0000 (UTC) Received: (qmail 74122 invoked by uid 500); 11 Nov 2014 22:51:23 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 74079 invoked by uid 500); 11 Nov 2014 22:51:23 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 74067 invoked by uid 99); 11 Nov 2014 22:51:23 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Nov 2014 22:51:23 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 11 Nov 2014 22:51:21 +0000 Received: (qmail 73979 invoked by uid 99); 11 Nov 2014 22:51:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Nov 2014 22:51:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 68BF21DFEAB; Tue, 11 Nov 2014 22:51:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2231177974273583234==" MIME-Version: 1.0 Subject: Re: Review Request 27889: Send an event for host attributes changing rather than maintenance mode changing. From: "Kevin Sweeney" To: "Kevin Sweeney" , "Joshua Cohen" Cc: "Bill Farner" , "Aurora" Date: Tue, 11 Nov 2014 22:51:04 -0000 Message-ID: <20141111225104.19819.49072@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/27889/ X-Sender: "Kevin Sweeney" References: <20141111224256.19819.31937@reviews.apache.org> In-Reply-To: <20141111224256.19819.31937@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============2231177974273583234== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27889/#review60886 ----------------------------------------------------------- Ship it! src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java Is this needed anymore? Maintenance doesn't have a dependency on pubsub anymore right? - Kevin Sweeney On Nov. 11, 2014, 2:42 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27889/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2014, 2:42 p.m.) > > > Review request for Aurora, Joshua Cohen and Kevin Sweeney. > > > Bugs: AURORA-913 > https://issues.apache.org/jira/browse/AURORA-913 > > > Repository: aurora > > > Description > ------- > > One step closer to caching host attributes. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/app/AppModule.java fef76f5069a80959eaba04f1b4b93ff3f6ba43dd > src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 14c3e3a593f72af696106d948767d85075b8726b > src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 9c095d932ada9f42cd473bc5d782883b0522c3cf > src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 0ba31ac5b17dd6dfa4e5f58d4e018cdb9b78172f > src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 88418e61a371626d2c6390a36d3a3284db8d76be > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 32890f5b390214bfa630dae0445fdde735f98ccf > src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java c6250b4a1b4cf168c451f1cfb87a02ef2ce4841d > src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 662ebdceff580af0a05f9a89d50ca1c90ddc9070 > src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 2f525104022448c200bfddc5a88252987fc86d0f > src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 7736d4cec260eba0938acaf9f884597a3e35f08e > src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java 99fa11ba15f1af9a4fd6fc31bb45020083d11806 > src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java e884209fd5965e50847f14b09a43f6aba4946b7e > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java c6ff43fdc07183d8e30d3db0a1af7c762255076f > src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java a553c566a14eda29862fe414f348dc071d0e638c > > Diff: https://reviews.apache.org/r/27889/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > > --===============2231177974273583234==--