Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8658D1781B for ; Fri, 7 Nov 2014 21:59:28 +0000 (UTC) Received: (qmail 93589 invoked by uid 500); 7 Nov 2014 21:59:28 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 93548 invoked by uid 500); 7 Nov 2014 21:59:28 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 93533 invoked by uid 99); 7 Nov 2014 21:59:27 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Nov 2014 21:59:27 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 07 Nov 2014 21:59:05 +0000 Received: (qmail 89553 invoked by uid 99); 7 Nov 2014 21:59:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Nov 2014 21:59:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 761301DFD20; Fri, 7 Nov 2014 21:59:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7864187833154642923==" MIME-Version: 1.0 Subject: Review Request 27747: Splitting cron and non-cron job creation in client v2. From: "Maxim Khutornenko" To: "Bill Farner" , "David McLaughlin" Cc: "Aurora" , "Maxim Khutornenko" Date: Fri, 07 Nov 2014 21:59:06 -0000 Message-ID: <20141107215906.12275.6027@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/27747/ X-Sender: "Maxim Khutornenko" Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============7864187833154642923== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27747/ ----------------------------------------------------------- Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-917 https://issues.apache.org/jira/browse/AURORA-917 Repository: aurora Description ------- These fail-fast checks finalize the cron/non-cron split in v2 job creation: Diffs ----- src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 175bba24a11587a4c0c595588a01f9e6503442fc src/main/python/apache/aurora/client/cli/cron.py e0510df2f0e076c96d08e7b8562573e4b487479c src/main/python/apache/aurora/client/cli/jobs.py b4d9360ed71953e5733e4bc0ba8acaaf01cf6da0 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b42f6e2d23eb44605cc84ce01a80f10344a7e43f src/test/python/apache/aurora/client/cli/test_create.py 1dec54c0da234cccc6d4091bb3fda4508836aac0 src/test/python/apache/aurora/client/cli/test_cron.py 029a0c57c32ad799165099de165328ad7e81369a src/test/python/apache/aurora/client/cli/util.py 154fb3a7170ae81548fcbc9f3cdd6dcf9bf1942d Diff: https://reviews.apache.org/r/27747/diff/ Testing ------- ./gradlew -Pq build ./pants src/tests/python:all vagrant@192:~$ aurora2 job create devcluster/vagrant/test/cron_hello_world4 aurora/examples/jobs/cron_hello_world.aurora Error executing command: Cron jobs may only be scheduled with "aurora cron schedule" command vagrant@192:~$ aurora2 cron schedule devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora Error executing command: Non-cron jobs may only be created with "aurora job create" command Thanks, Maxim Khutornenko --===============7864187833154642923==--