Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C82D317ED0 for ; Fri, 7 Nov 2014 19:14:17 +0000 (UTC) Received: (qmail 41486 invoked by uid 500); 7 Nov 2014 19:14:17 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 41448 invoked by uid 500); 7 Nov 2014 19:14:17 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 41433 invoked by uid 99); 7 Nov 2014 19:14:17 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Nov 2014 19:14:17 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 07 Nov 2014 19:13:54 +0000 Received: (qmail 36065 invoked by uid 99); 7 Nov 2014 19:12:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Nov 2014 19:12:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 522CE1DFD25; Fri, 7 Nov 2014 19:12:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2936155331361131743==" MIME-Version: 1.0 Subject: Re: Review Request 27712: Fixing beta-update OK status messaging. From: "Maxim Khutornenko" To: "Bill Farner" Cc: "Aurora" , "Maxim Khutornenko" Date: Fri, 07 Nov 2014 19:12:40 -0000 Message-ID: <20141107191240.10454.1876@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/27712/ X-Sender: "Maxim Khutornenko" References: <20141107180515.10454.29044@reviews.apache.org> In-Reply-To: <20141107180515.10454.29044@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============2936155331361131743== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Nov. 7, 2014, 6:05 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 1582 > > > > > > Please remove. The API really should not be sending back messages of the form "i did what you asked me to do." Sticking strictly to only including a response message when it is necessary allows us to have a client that is not overly-chatty. That was simplifying client handling a bit but I see your point. Changed. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27712/#review60352 ----------------------------------------------------------- On Nov. 7, 2014, 12:30 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27712/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2014, 12:30 a.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-784 > https://issues.apache.org/jira/browse/AURORA-784 > > > Repository: aurora > > > Description > ------- > > Fixing beta-update OK status messaging: > > vagrant@192:~$ aurora2 beta-update start devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora > Job update has started. > vagrant@192:~$ aurora2 beta-update start devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora > Job is unchanged by proposed update. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 175bba24a11587a4c0c595588a01f9e6503442fc > src/main/python/apache/aurora/client/cli/context.py 0a3c2236916f52919b48e9254929c2fbe9eb5252 > src/main/python/apache/aurora/client/cli/jobs.py b4d9360ed71953e5733e4bc0ba8acaaf01cf6da0 > src/main/python/apache/aurora/client/cli/quota.py 3130bfbaca994fb9b8c8f0eb9d32b284fd6e6ce2 > src/main/python/apache/aurora/client/cli/update.py 0797e30bb40eb983a5ba2f47d1e1955049fb345a > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b42f6e2d23eb44605cc84ce01a80f10344a7e43f > src/test/python/apache/aurora/client/cli/test_supdate.py 8943f8c1a5809c197d5d1f3dd6f24999f0dfe359 > > Diff: https://reviews.apache.org/r/27712/diff/ > > > Testing > ------- > > ./gradlew -Pq build > ./pants src/tests/python:all > > > Thanks, > > Maxim Khutornenko > > --===============2936155331361131743==--