Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 13A5A1759D for ; Fri, 7 Nov 2014 02:41:28 +0000 (UTC) Received: (qmail 8993 invoked by uid 500); 7 Nov 2014 02:41:28 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 8951 invoked by uid 500); 7 Nov 2014 02:41:28 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 8940 invoked by uid 99); 7 Nov 2014 02:41:27 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Nov 2014 02:41:27 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 07 Nov 2014 02:41:26 +0000 Received: (qmail 8836 invoked by uid 99); 7 Nov 2014 02:41:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Nov 2014 02:41:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9B8171DFC45; Fri, 7 Nov 2014 02:41:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3645969121794318971==" MIME-Version: 1.0 Subject: Re: Review Request 27716: Remove SchedulerActive, replace with explicit lifecycle. From: "Kevin Sweeney" To: "Bill Farner" Cc: "Aurora ReviewBot" , "Aurora" , "Maxim Khutornenko" , "Kevin Sweeney" Date: Fri, 07 Nov 2014 02:41:09 -0000 Message-ID: <20141107024109.10454.19308@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/27716/ X-Sender: "Kevin Sweeney" References: <20141107024042.12275.60003@reviews.apache.org> In-Reply-To: <20141107024042.12275.60003@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============3645969121794318971== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27716/ ----------------------------------------------------------- (Updated Nov. 6, 2014, 6:41 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-920 https://issues.apache.org/jira/browse/AURORA-920 Repository: aurora Description ------- Remove SchedulerActive, replace with explicit services. This is the first part of a larger change that will allow us to make pubsub events async as it makes the dependency on subscribers processing a SchedulerActive event explicit. Diffs ----- src/main/java/org/apache/aurora/GuavaUtils.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/SchedulerActive.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 823ff75559e5155d851d599fd0cd311a03f39daa src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 09c8bc93d95c7a82265730480747554512a0ffd4 src/main/java/org/apache/aurora/scheduler/TaskVars.java 3ebb8d0c96a13391438eab9e4b77bf152e9773fd src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 1d3978386299d823d9ce6e258760b2f21e48de83 src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 10465ce54ec2446ce0dd85ec28ad433ebb7f7660 src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java e7fafec45e74008a4eac0787ed9c12b3ce81d4c0 src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java b5c8533bafbd13c73371ca1124036a11010e7c20 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java 463a3aaffa18240c7d1cb83dfc67903baf2dd707 src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java d4d3a25cd9bc5dafce6ef1d6d3295f56b0b8a224 src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java e091ca39f4de43a285575e32ceaa7f1521cf67af src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java f3c7c5bd53df759432beda4fa46db49fd0514b42 src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 850c9a97df6e3c71bbdeef03fed30153a04b45d8 src/test/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriberTest.java c53cfe0bfb74a30b99e45b6303d6651cdc44bbdd src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 8baec047a2e0436847ff4558c56428d9d4c2da5a Diff: https://reviews.apache.org/r/27716/diff/ Testing (updated) ------- ./gradlew -Pq build test_end_to_end.sh Thanks, Kevin Sweeney --===============3645969121794318971==--