Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8AA2E17E5D for ; Thu, 6 Nov 2014 01:49:14 +0000 (UTC) Received: (qmail 10901 invoked by uid 500); 6 Nov 2014 01:49:14 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 10872 invoked by uid 500); 6 Nov 2014 01:49:14 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 10861 invoked by uid 99); 6 Nov 2014 01:49:13 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Nov 2014 01:49:13 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,MANY_SPAN_IN_TEXT,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 06 Nov 2014 01:49:12 +0000 Received: (qmail 10420 invoked by uid 99); 6 Nov 2014 01:48:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Nov 2014 01:48:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9D3AF1DFC29; Thu, 6 Nov 2014 01:48:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6465810990529293332==" MIME-Version: 1.0 Subject: Re: Review Request 27657: Print out the job url after scheduling a cron job. From: "Aurora ReviewBot" To: "Bill Farner" Cc: "Aurora ReviewBot" , "Aurora" , "Zameer Manji" Date: Thu, 06 Nov 2014 01:48:55 -0000 Message-ID: <20141106014855.10454.58158@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/27657/ X-Sender: "Aurora ReviewBot" References: <20141106013354.10455.88942@reviews.apache.org> In-Reply-To: <20141106013354.10455.88942@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============6465810990529293332== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27657/#review60089 ----------------------------------------------------------- Master (0ad2fca) is red with this patch. ./build-support/jenkins/build.sh src/test/python/apache/aurora/client/cli/test_cron.py::TestCronNoun::test_cron_status PASSED src/test/python/apache/aurora/client/cli/test_cron.py::TestCronNoun::test_cron_status_multiple_jobs PASSED src/test/python/apache/aurora/client/cli/test_cron.py::TestCronNoun::test_deschedule_cron_deep_api PASSED src/test/python/apache/aurora/client/cli/test_cron.py::TestCronNoun::test_schedule_cron_deep_api Fatal error running command; traceback can be found in /home/jenkins/.aurora/errors/aurora-1415238529.error-log FAILED =================================== FAILURES =================================== ___________________ TestCronNoun.test_schedule_cron_deep_api ___________________ self = def test_schedule_cron_deep_api(self): (mock_api, mock_scheduler_proxy) = self.create_mock_api() with contextlib.nested( patch('time.sleep'), patch('apache.aurora.client.api.SchedulerProxy', return_value=mock_scheduler_proxy), patch('apache.aurora.client.factory.CLUSTERS', new=self.TEST_CLUSTERS)): mock_scheduler_proxy.scheduleCronJob.return_value = self.create_simple_success_response() with temporary_file() as fp: fp.write(self.get_valid_config()) fp.flush() cmd = AuroraCommandLine() result = cmd.execute(['cron', 'schedule', 'west/bozo/test/hello', fp.name]) > assert result == EXIT_OK E AssertionError: assert 20 == 0 src/test/python/apache/aurora/client/cli/test_cron.py:100: AssertionError generated xml file: /jenkins/workspace/AuroraBot/dist/test-results/src.test.python.apache.aurora.client.cli.cron.xml !!!!!!!!!!!!!!!!!!!! Interrupted: stopping after 1 failures !!!!!!!!!!!!!!!!!!!! ====================== 1 failed, 3 passed in 1.55 seconds ====================== Build operating on top level addresses: set([BuildFileAddress(/jenkins/workspace/AuroraBot/src/test/python/BUILD, all)]) src.test.python.apache.aurora.admin.admin_util ..... SUCCESS src.test.python.apache.aurora.admin.host_maintenance ..... SUCCESS src.test.python.apache.aurora.client.api.api ..... SUCCESS src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS src.test.python.apache.aurora.client.api.mux ..... SUCCESS src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS src.test.python.apache.aurora.client.api.restarter ..... SUCCESS src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS src.test.python.apache.aurora.client.api.sla ..... SUCCESS src.test.python.apache.aurora.client.api.updater ..... SUCCESS src.test.python.apache.aurora.client.api.updater_util ..... SUCCESS src.test.python.apache.aurora.client.binding_helper ..... SUCCESS src.test.python.apache.aurora.client.cli.api ..... SUCCESS src.test.python.apache.aurora.client.cli.bridge ..... SUCCESS src.test.python.apache.aurora.client.cli.command_hooks ..... SUCCESS src.test.python.apache.aurora.client.cli.cron ..... FAILURE src.test.python.apache.aurora.client.config ..... SUCCESS - Aurora ReviewBot On Nov. 6, 2014, 1:33 a.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27657/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 1:33 a.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-857 > https://issues.apache.org/jira/browse/AURORA-857 > > > Repository: aurora > > > Description > ------- > > Print out the job url after scheduling a cron job. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 > src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a > > Diff: https://reviews.apache.org/r/27657/diff/ > > > Testing > ------- > > ./pants build --timeout=60 src/test/python:all -vxs > > ```` > vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 cron schedule devcluster/www-data/test/cron_hello_world /vagrant/examples/jobs/cron_hello_world.aurora > log(info): Registering job cron_hello_world with cron > cron schedule created at http://vagrant-ubuntu-trusty-64:8081/scheduler/www-data/test/cron_hello_world > ```` > > > Thanks, > > Zameer Manji > > --===============6465810990529293332==--