Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0D3B61797C for ; Thu, 6 Nov 2014 00:34:33 +0000 (UTC) Received: (qmail 54889 invoked by uid 500); 6 Nov 2014 00:34:33 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 54867 invoked by uid 500); 6 Nov 2014 00:34:32 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 54853 invoked by uid 99); 6 Nov 2014 00:34:32 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Nov 2014 00:34:32 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 06 Nov 2014 00:34:30 +0000 Received: (qmail 54550 invoked by uid 99); 6 Nov 2014 00:34:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Nov 2014 00:34:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5E41C1DFC00; Thu, 6 Nov 2014 00:34:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0940402717238004631==" MIME-Version: 1.0 Subject: Re: Review Request 27650: Remove duplicate call to log handling code. From: "Aurora ReviewBot" To: "Bill Farner" , "Joshua Cohen" Cc: "Aurora ReviewBot" , "Aurora" , "Zameer Manji" Date: Thu, 06 Nov 2014 00:34:14 -0000 Message-ID: <20141106003414.10454.18007@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/27650/ X-Sender: "Aurora ReviewBot" References: <20141106000246.10455.11247@reviews.apache.org> In-Reply-To: <20141106000246.10455.11247@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============0940402717238004631== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27650/#review60072 ----------------------------------------------------------- Ship it! Master (0ad2fca) is green with this patch. ./build-support/jenkins/build.sh - Aurora ReviewBot On Nov. 6, 2014, 12:02 a.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27650/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 12:02 a.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-793 > https://issues.apache.org/jira/browse/AURORA-793 > > > Repository: aurora > > > Description > ------- > > Remove duplicate call to log handling code. This duplicate call added another stderr handler to the logger which caused each message to be printed twice to stderr. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/client.py 0cb69448cd24372067ac845eca5862bc3d3a46a9 > > Diff: https://reviews.apache.org/r/27650/diff/ > > > Testing > ------- > > vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job create -v devcluster/www-data/devel/not_here /vagrant/not_real.aurora > log(info): Error executing command: Error loading configuration: [Errno 2] No such file or directory: '/vagrant/not_real.aurora' > Error executing command: Error loading configuration: [Errno 2] No such file or directory: '/vagrant/not_real.aurora' > > > Thanks, > > Zameer Manji > > --===============0940402717238004631==--