Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============2887176049621321164=="
MIME-Version: 1.0
Subject: Re: Review Request 27586: Increase robustness when reading PEX-INFO
From: "Kevin Sweeney" <kevints@apache.org>
To: "Bill Farner" <wfarner@apache.org>
Cc: "Aurora" <reviews@aurora.incubator.apache.org>,
 "Zameer Manji" <zmanji@twopensource.com>,
 "Kevin Sweeney" <kevints@apache.org>
Date: Tue, 04 Nov 2014 19:57:55 -0000
Message-ID: <20141104195755.10455.39805@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Kevin Sweeney" <noreply@reviews.apache.org>
References: <20141104195516.10455.69778@reviews.apache.org>
In-Reply-To: <20141104195516.10455.69778@reviews.apache.org>
Reply-To: "Kevin Sweeney" <kevints@apache.org>

--===============2887176049621321164==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27586/#review59816
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Sweeney


On Nov. 4, 2014, 11:55 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27586/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 11:55 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-456
>     https://issues.apache.org/jira/browse/AURORA-456
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This patch prevents aurora version from crashing when it is built with a different version of pants.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c 
> 
> Diff: https://reviews.apache.org/r/27586/diff/
> 
> 
> Testing
> -------
> 
> [tw-mbp-zmanji aurora (fix-version)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2
> Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)])
> Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)):
> Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex
> [tw-mbp-zmanji aurora (fix-version)]$ ./pants src/main/python/apache/aurora/client/bin:aurora_client
> Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)])
> Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)):
> Wrote /Users/zmanji/workspace/aurora/dist/aurora_client.pex
> [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora2.pex version
> Aurora client build info:
> 	sha: d03187404dac583884a979dd302dd3cd36163c98
> 	date: Tuesday Nov 04, 2014 11:39:07
> Aurora API version: APIVersion(major=3)
> [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora_client.pex version
> Aurora client build info:
> 	sha: d03187404dac583884a979dd302dd3cd36163c98
> 	date: Tuesday Nov 04, 2014 11:39:18
> Aurora API version: APIVersion(major=3)
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


--===============2887176049621321164==--