Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 93F79173B7 for ; Mon, 3 Nov 2014 21:25:52 +0000 (UTC) Received: (qmail 85454 invoked by uid 500); 3 Nov 2014 21:25:52 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 85412 invoked by uid 500); 3 Nov 2014 21:25:52 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 85401 invoked by uid 99); 3 Nov 2014 21:25:52 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Nov 2014 21:25:52 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 03 Nov 2014 21:25:29 +0000 Received: (qmail 83435 invoked by uid 99); 3 Nov 2014 21:25:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Nov 2014 21:25:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 638671DDC8D; Mon, 3 Nov 2014 21:25:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3822938871395678315==" MIME-Version: 1.0 Subject: Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states. From: "Bill Farner" To: "Maxim Khutornenko" , "Kevin Sweeney" Cc: "Bill Farner" , "Aurora ReviewBot" , "Aurora" Date: Mon, 03 Nov 2014 21:25:31 -0000 Message-ID: <20141103212531.10455.68578@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/27467/ X-Sender: "Bill Farner" References: <20141101174845.7137.38728@reviews.apache.org> In-Reply-To: <20141101174845.7137.38728@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============3822938871395678315== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27467/ ----------------------------------------------------------- (Updated Nov. 3, 2014, 9:25 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-910 https://issues.apache.org/jira/browse/AURORA-910 Repository: aurora Description ------- Retry Driver.killTask periodically until the task changes states. Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java df7e56a955fef21d48e75797bb5761453ae1e57a src/main/java/org/apache/aurora/scheduler/async/KillRetry.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java 748aac83db7c470dc7aed7936e629400c3e6c2d8 src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 1688a339a1a9c4072d7f834963cb5ccad6fe0736 Diff: https://reviews.apache.org/r/27467/diff/ Testing ------- Thanks, Bill Farner --===============3822938871395678315==--